From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jose Abreu Subject: Re: [PATCH net-next 1/4] net: phy: Use C45 Helpers when forcing PHY Date: Tue, 23 Oct 2018 11:20:26 +0100 Message-ID: <62064558-d1dd-a1cb-8697-2b7e8206ce3b@synopsys.com> References: <8e1a35a5-de85-e7b3-c9f3-524b3313feaa@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , "David S. Miller" , Joao Pinto To: Florian Fainelli , Jose Abreu , Return-path: Received: from smtprelay4.synopsys.com ([198.182.47.9]:37176 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726885AbeJWSnS (ORCPT ); Tue, 23 Oct 2018 14:43:18 -0400 In-Reply-To: <8e1a35a5-de85-e7b3-c9f3-524b3313feaa@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 22-10-2018 18:11, Florian Fainelli wrote: > On 10/22/18 3:32 AM, Jose Abreu wrote: >> If PHY is in force state and we have a C45 phy we need to use the >> standard C45 helpers and not the C22 ones. >> >> Signed-off-by: Jose Abreu >> Cc: Andrew Lunn >> Cc: Florian Fainelli >> Cc: "David S. Miller" >> Cc: Joao Pinto >> --- >> drivers/net/phy/phy.c | 2 +- >> include/linux/phy.h | 8 ++++++++ >> 2 files changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c >> index 1d73ac3309ce..0ff4946e208e 100644 >> --- a/drivers/net/phy/phy.c >> +++ b/drivers/net/phy/phy.c >> @@ -995,7 +995,7 @@ void phy_state_machine(struct work_struct *work) >> } >> break; >> case PHY_FORCING: >> - err = genphy_update_link(phydev); >> + err = phy_update_link(phydev); >> if (err) >> break; >> >> diff --git a/include/linux/phy.h b/include/linux/phy.h >> index 3ea87f774a76..02c2ee8bc05b 100644 >> --- a/include/linux/phy.h >> +++ b/include/linux/phy.h >> @@ -1044,6 +1044,14 @@ static inline int phy_read_status(struct phy_device *phydev) >> return genphy_read_status(phydev); >> } >> >> +static inline int phy_update_link(struct phy_device *phydev) >> +{ >> + if (phydev->is_c45) >> + return gen10g_read_status(phydev); > Should not this be genphy_c45_read_link() for symmetry with > genphy_update_link() which only updates phydev->link? Hmmm, genphy_c45_read_link() does not update phydev->link ... I can create a new gen10g_update_link() that wraps around genphy_c45_read_link() and updates link ... Thanks and Best Regards, Jose Miguel Abreu