From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, mcoquelin.stm32@gmail.com,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sihui.liu@ingenic.com, jun.jiang@ingenic.com,
sernia.zhou@foxmail.com, paul@crapouillou.net
Subject: Re: [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support.
Date: Tue, 8 Jun 2021 21:48:38 +0800 [thread overview]
Message-ID: <62ad605f-3689-cab3-e43e-9b6954da8df3@wanyeetech.com> (raw)
In-Reply-To: <YL9gr2QQ/YEXNUmP@lunn.ch>
Hello Andrew,
On 2021/6/8 下午8:21, Andrew Lunn wrote:
> Please wrap your text to around 75 characters per line.
Sure.
>
> I suspect you don't understand RGMII delays. As i said, normally, the
> MAC does not add delays, the PHY does. Please take a closer look at
> this.
According to the description of ethernet-controller.yaml, "rgmii" seems
to allow MAC to add TX delay (the description in ethernet-controller.yaml
is "RX and TX delays are added by the MAC when required"), while rgmii-id
and rgmii-txid do not allow MAC to add delay (the description in
ethernet-controller.yaml is"RGMII with internal RX and TX delays provided
by the PHY, the MAC should not add the RX or TX delays in this case" and
"RGMII with internal TX delay provided by the PHY, the MAC should not add
an TX delay in this case"), I will add support for the other three RGMII
modes
in the next version (I forgot to reply to this in the previous email).
Thanks and best regards!
next prev parent reply other threads:[~2021-06-08 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 17:27 [PATCH 0/2] Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-07 17:27 ` [PATCH 1/2] dt-bindings: dwmac: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-06-07 17:27 ` [PATCH 2/2] net: stmmac: Add Ingenic SoCs MAC support 周琰杰 (Zhou Yanjie)
2021-06-08 0:01 ` Andrew Lunn
2021-06-08 11:33 ` Zhou Yanjie
2021-06-08 12:21 ` Andrew Lunn
2021-06-08 13:48 ` Zhou Yanjie [this message]
2021-06-08 14:04 ` Andrew Lunn
2021-06-08 8:46 ` Paul Cercueil
2021-06-08 13:24 ` Zhou Yanjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ad605f-3689-cab3-e43e-9b6954da8df3@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=aric.pzqi@ingenic.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=joabreu@synopsys.com \
--cc=jun.jiang@ingenic.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=peppe.cavallaro@st.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=sihui.liu@ingenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).