From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>,
"Andrew Lunn" <andrew@lunn.ch>,
jim.cromie@gmail.com, "Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: "Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Thu, 22 Oct 2020 09:15:50 +0200 [thread overview]
Message-ID: <633bbf18-1aec-4b2a-7967-898cde1930aa@samsung.com> (raw)
In-Reply-To: <20201021214910.20001-4-l.stelmach@samsung.com>
On 21.10.2020 23:49, Łukasz Stelmach wrote:
> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
> supports SPI connection.
>
> The driver has been ported from the vendor kernel for ARTIK5[2]
> boards. Several changes were made to adapt it to the current kernel
> which include:
>
> + updated DT configuration,
> + clock configuration moved to DT,
> + new timer, ethtool and gpio APIs,
> + dev_* instead of pr_* and custom printk() wrappers,
> + removed awkward vendor power managemtn.
>
> [1] https://www.asix.com.tw/products.php?op=pItemdetail&PItemID=104;65;86&PLine=65
> [2] https://git.tizen.org/cgit/profile/common/platform/kernel/linux-3.10-artik/
>
> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
> chips are not compatible. Hence, two separate drivers are required.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
coś zaszalałeś, jak dobry koreański kod - push bez kompilacji ;)
drivers/net/ethernet/asix/ax88796c_main.c:758:13: error: static
declaration of ‘ax88796c_set_csums’ follows non-static declaration
static void ax88796c_set_csums(struct ax88796c_device *ax_local)
^
In file included from drivers/net/ethernet/asix/ax88796c_main.c:12:0:
drivers/net/ethernet/asix/ax88796c_ioctl.h:24:6: note: previous
declaration of ‘ax88796c_set_csums’ was here
void ax88796c_set_csums(struct ax88796c_device *ax_local);
^
scripts/Makefile.build:283: recipe for target
'drivers/net/ethernet/asix/ax88796c_main.o' failed
make[4]: *** [drivers/net/ethernet/asix/ax88796c_main.o] Error 1
scripts/Makefile.build:500: recipe for target
'drivers/net/ethernet/asix' failed
make[3]: *** [drivers/net/ethernet/asix] Error 2
scripts/Makefile.build:500: recipe for target 'drivers/net/ethernet' failed
make[2]: *** [drivers/net/ethernet] Error 2
scripts/Makefile.build:500: recipe for target 'drivers/net' failed
make[1]: *** [drivers/net] Error 2
> ...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-10-22 7:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201021214930eucas1p1cf406b35bbe4b643db287643e4a5b85b@eucas1p1.samsung.com>
2020-10-21 21:49 ` [PATCH v3 0/5] AX88796C SPI Ethernet Adapter Łukasz Stelmach
[not found] ` <CGME20201021214933eucas1p26e8ee82f237e977e8b3324145a929a1a@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
2020-10-22 6:53 ` Krzysztof Kozlowski
2020-10-26 15:10 ` Rob Herring
[not found] ` <CGME20201021214933eucas1p152c8fc594793aca56a1cbf008f8415a4@eucas1p1.samsung.com>
2020-10-21 21:49 ` [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-10-22 6:55 ` Krzysztof Kozlowski
2020-10-23 16:05 ` Rob Herring
2020-10-23 16:27 ` Krzysztof Kozlowski
[not found] ` <CGME20201023182136eucas1p28518b30e23ae4204840c3d5526bd3400@eucas1p2.samsung.com>
2020-10-23 18:21 ` Lukasz Stelmach
[not found] ` <CGME20201021214933eucas1p2fd4e5ccc172f3e22fe0d7009d8b2742d@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-10-22 0:45 ` kernel test robot
2020-10-22 7:15 ` Marek Szyprowski [this message]
[not found] ` <CGME20201022100133eucas1p132ef97a9ac767bd357f50034c47d6d1a@eucas1p1.samsung.com>
2020-10-22 10:01 ` Lukasz Stelmach
[not found] ` <CGME20201021214934eucas1p273214a19e3a775512ab3090d243260db@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
[not found] ` <CGME20201021214934eucas1p2d4acc48c40f37763c276d8d275fa9c15@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 5/5] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=633bbf18-1aec-4b2a-7967-898cde1930aa@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).