From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFBFC47404 for ; Fri, 11 Oct 2019 09:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3045C2196E for ; Fri, 11 Oct 2019 09:25:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dlink.ru header.i=@dlink.ru header.b="D0YMuiUt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727594AbfJKJZJ (ORCPT ); Fri, 11 Oct 2019 05:25:09 -0400 Received: from fd.dlink.ru ([178.170.168.18]:33774 "EHLO fd.dlink.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbfJKJZJ (ORCPT ); Fri, 11 Oct 2019 05:25:09 -0400 Received: by fd.dlink.ru (Postfix, from userid 5000) id EF5BC1B219DF; Fri, 11 Oct 2019 12:25:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru EF5BC1B219DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dlink.ru; s=mail; t=1570785907; bh=2zbqnAAuO645gpFzhhwvyF+3tN85Ck5znV40ghXMwBs=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=D0YMuiUtay0eLi/niPZrXHdGMio2Bm8Kl7iWmcxTX3uq/ONSHV5W4TJujS0M+0Uy+ 898QX9pJ8YvsCl9jOEvxvAbnK/b00AAjoxyehaeg9pSqVBMeL4EKi27Js5qW4Bv9LZ ne9WFd5NPHZWXd+4YZrSBpEkcd2pfTbDwcTSQ0d8= Received: from mail.rzn.dlink.ru (mail.rzn.dlink.ru [178.170.168.13]) by fd.dlink.ru (Postfix) with ESMTP id E03B11B20208; Fri, 11 Oct 2019 12:25:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 fd.dlink.ru E03B11B20208 Received: by mail.rzn.dlink.ru (Postfix, from userid 5000) id C62771B218D8; Fri, 11 Oct 2019 12:25:03 +0300 (MSK) Received: from mail.rzn.dlink.ru (localhost [127.0.0.1]) by mail.rzn.dlink.ru (Postfix) with ESMTPA id 4994D1B218D8; Fri, 11 Oct 2019 12:24:56 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Fri, 11 Oct 2019 12:24:56 +0300 From: Alexander Lobakin To: Edward Cree Cc: "David S. Miller" , Jiri Pirko , Eric Dumazet , Ido Schimmel , Paolo Abeni , Petr Machata , Sabrina Dubroca , Florian Fainelli , Jassi Brar , Ilias Apalodimas , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next1/2] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() In-Reply-To: References: <20191010144226.4115-1-alobakin@dlink.ru> <20191010144226.4115-2-alobakin@dlink.ru> Message-ID: <6404af326e37c0f34c3dbc9f33a1009a@dlink.ru> X-Sender: alobakin@dlink.ru User-Agent: Roundcube Webmail/1.3.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Edward Cree wrote 11.10.2019 12:20: >>> On 10/10/2019 15:42, Alexander Lobakin wrote: >>>> Commit 323ebb61e32b4 ("net: use listified RX for handling GRO_NORMAL >>>> skbs") made use of listified skb processing for the users of >>>> napi_gro_frags(). >>>> The same technique can be used in a way more common >>>> napi_gro_receive() >>>> to speed up non-merged (GRO_NORMAL) skbs for a wide range of >>>> drivers, >>>> including gro_cells and mac80211 users. >>>> >>>> Signed-off-by: Alexander Lobakin > Acked-by: Edward Cree > but I think this needs review from the socionext folks as well. Thanks! Sure, I'm waiting for any other possible comments. Regards, ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ