netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Network Development <netdev@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux <linux@armlinux.org.uk>
Subject: vlan_filtering=1 breaks all traffic (was: Re: warnings from MTU setting on switch ports)
Date: Sat, 5 Dec 2020 15:49:02 +0100	[thread overview]
Message-ID: <6424c14e-bd25-2a06-cf0b-f1a07f9a3604@prevas.dk> (raw)
In-Reply-To: <61a2e853-9d81-8c1a-80f0-200f5d8dc650@prevas.dk>

On 30/11/2020 23.13, Rasmus Villemoes wrote:
> On 30/11/2020 17.04, Vladimir Oltean wrote:

> Thanks, but I don't think that will change anything. -34 is -ERANGE.
>> But you might also want to look into adding .ndo_change_mtu for
>> ucc_geth. 
> 
> Well, that was what I first did, but I'm incapable of making sense of
> the QE reference manual. Perhaps, given the domain of your email
> address, you could poke someone that might know what would need to be done?
> 
> In any case, something else seems to be broken with 5.9; no network
> traffic seems to be working (but the bridge creation etc. seems to work
> just the same, link status works, and "ip link show" shows the same
> things as in 4.19). So until I figure that out I can't play around with
> modifying ucc_geth.

So, I found out that the problem disappers when I disable
vlan_filtering, and googling then led me to Russell's patches from
around March
(https://patchwork.ozlabs.org/project/netdev/cover/20200218114515.GL18808@shell.armlinux.org.uk/).

But, unlike from what I gather from Russell's description, the problem
is there whether or not the bridge is created with vlan_filtering
enabled from the outset or not. Also, cherry-picking 517648c8d1 to
5.9.12 doesn't help. The problem also exists on 5.4.80, and (somewhat
naively) backporting 54a0ed0df496 as well as 517648c8d1 doesn't change that.

So I'm out of ideas. I also tried booting a 5.3, but that had some
horrible UBI/nand failure, and since the mv88e6250 support only landed
in 5.3, it's rather difficult to try kernels further back.

Does anyone know what might have happened between 4.19 and 5.4 that
caused this change in behaviour for Marvell switches?

Rasmus

  parent reply	other threads:[~2020-12-05 14:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 14:30 warnings from MTU setting on switch ports Rasmus Villemoes
2020-11-30 16:04 ` Vladimir Oltean
2020-11-30 22:13   ` Rasmus Villemoes
2020-11-30 22:35     ` Vladimir Oltean
2020-11-30 22:50       ` Rasmus Villemoes
2020-11-30 23:11       ` Andrew Lunn
2020-12-05 14:49     ` Rasmus Villemoes [this message]
2020-12-05 15:45       ` vlan_filtering=1 breaks all traffic (was: Re: warnings from MTU setting on switch ports) Russell King - ARM Linux admin
2020-12-05 16:02         ` vlan_filtering=1 breaks all traffic Rasmus Villemoes
2020-12-05 19:03       ` vlan_filtering=1 breaks all traffic (was: Re: warnings from MTU setting on switch ports) Vladimir Oltean
2020-12-05 20:13         ` vlan_filtering=1 breaks all traffic Rasmus Villemoes
2020-12-06 19:45           ` Vladimir Oltean
2020-12-07 19:43             ` Rasmus Villemoes
2020-12-07 20:15               ` Vladimir Oltean
2020-12-08  2:22                 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6424c14e-bd25-2a06-cf0b-f1a07f9a3604@prevas.dk \
    --to=rasmus.villemoes@prevas.dk \
    --cc=f.fainelli@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).