From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Neel Patel (neepatel)" Subject: RE: [PATCH] drivers/net: enic: release rtnl_lock on error-path Date: Mon, 8 Jul 2013 16:26:58 +0000 Message-ID: <644DFB2E795E0348A1614A34EE0D35711837FDB1@xmb-rcd-x05.cisco.com> References: <20130708072251.20540.50413.stgit@zurg> <51DAE823.4030406@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Christian Benvenuti (benve)" To: "Nishank Trivedi (nistrive)" , Konstantin Khlebnikov Return-path: In-Reply-To: <51DAE823.4030406@cisco.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org TG9va3MgZ29vZC4NCg0KVGhhbmtzIQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJv bTogTmlzaGFuayBUcml2ZWRpIChuaXN0cml2ZSkgDQpTZW50OiBNb25kYXksIEp1bHkgMDgsIDIw MTMgOToyNiBBTQ0KVG86IEtvbnN0YW50aW4gS2hsZWJuaWtvdg0KQ2M6IG5ldGRldkB2Z2VyLmtl cm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IE5lZWwgUGF0ZWwgKG5lZXBh dGVsKTsgQ2hyaXN0aWFuIEJlbnZlbnV0aSAoYmVudmUpDQpTdWJqZWN0OiBSZTogW1BBVENIXSBk cml2ZXJzL25ldDogZW5pYzogcmVsZWFzZSBydG5sX2xvY2sgb24gZXJyb3ItcGF0aA0KDQpPbiA3 LzgvMTMgMTI6MjIgQU0sIEtvbnN0YW50aW4gS2hsZWJuaWtvdiB3cm90ZToNCj4gZW5pY19jaGFu Z2VfbXR1X3dvcmsoKSBtdXN0IGNhbGwgcnRubF91bmxvY2soKSBvbiBhbGwgZXhpdGluZyBwYXRo cy4NCj4NCj4gU2lnbmVkLW9mZi1ieTogS29uc3RhbnRpbiBLaGxlYm5pa292IDxraGxlYm5pa292 QG9wZW52ei5vcmc+DQo+IENjOiBDaHJpc3RpYW4gQmVudmVudXRpIDxiZW52ZUBjaXNjby5jb20+ DQo+IENjOiBSb29wYSBQcmFiaHUgPHJvcHJhYmh1QGNpc2NvLmNvbT4NCj4gQ2M6IE5lZWwgUGF0 ZWwgPG5lZXBhdGVsQGNpc2NvLmNvbT4NCj4gQ2M6IE5pc2hhbmsgVHJpdmVkaSA8bmlzdHJpdmVA Y2lzY28uY29tPg0KPiAtLS0NCj4gICBkcml2ZXJzL25ldC9ldGhlcm5ldC9jaXNjby9lbmljL2Vu aWNfbWFpbi5jIHwgICAgMiArKw0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykN Cj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2Npc2NvL2VuaWMvZW5pY19t YWluLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9jaXNjby9lbmljL2VuaWNfbWFpbi5jDQo+IGlu ZGV4IDYzNWY1NTkuLjk5MmVjMmUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0 L2Npc2NvL2VuaWMvZW5pY19tYWluLmMNCj4gKysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvY2lz Y28vZW5pYy9lbmljX21haW4uYw0KPiBAQCAtMTc2MSw2ICsxNzYxLDcgQEAgc3RhdGljIHZvaWQg ZW5pY19jaGFuZ2VfbXR1X3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiAgIAllbmlj X3N5bmNocm9uaXplX2lycXMoZW5pYyk7DQo+ICAgCWVyciA9IHZuaWNfcnFfZGlzYWJsZSgmZW5p Yy0+cnFbMF0pOw0KPiAgIAlpZiAoZXJyKSB7DQo+ICsJCXJ0bmxfdW5sb2NrKCk7DQo+ICAgCQlu ZXRkZXZfZXJyKG5ldGRldiwgIlVuYWJsZSB0byBkaXNhYmxlIFJRLlxuIik7DQo+ICAgCQlyZXR1 cm47DQo+ICAgCX0NCj4gQEAgLTE3NzMsNiArMTc3NCw3IEBAIHN0YXRpYyB2b2lkIGVuaWNfY2hh bmdlX210dV93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykNCj4gICAJdm5pY19ycV9maWxs KCZlbmljLT5ycVswXSwgZW5pY19ycV9hbGxvY19idWYpOw0KPiAgIAkvKiBOZWVkIGF0IGxlYXN0 IG9uZSBidWZmZXIgb24gcmluZyB0byBnZXQgZ29pbmcgKi8NCj4gICAJaWYgKHZuaWNfcnFfZGVz Y191c2VkKCZlbmljLT5ycVswXSkgPT0gMCkgew0KPiArCQlydG5sX3VubG9jaygpOw0KPiAgIAkJ bmV0ZGV2X2VycihuZXRkZXYsICJVbmFibGUgdG8gYWxsb2MgcmVjZWl2ZSBidWZmZXJzLlxuIik7 DQo+ICAgCQlyZXR1cm47DQo+ICAgCX0NCj4NCg0KQWNrZWQuDQoNClRoYW5rcy4NCg==