From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com,
nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com,
Alan Winkowski <walan@marvell.com>
Subject: Re: [PATCH net] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift
Date: Thu, 20 Jun 2019 11:58:18 +0300 [thread overview]
Message-ID: <64727f68-866b-b2eb-38c9-5670efe68aaf@cogentembedded.com> (raw)
In-Reply-To: <20190619145413.21852-1-maxime.chevallier@bootlin.com>
On 19.06.2019 17:54, Maxime Chevallier wrote:
> The Header Parser allows identifying various fields in the packet
> headers, used for for various kind of filtering and classification
One "for" is enough. :-)
> steps.
>
> This is a re-entrant process, where the offset in the packet header
> depends on the previous lookup results. This offset is represented in
> the SRAM results of the TCAM, as a shift to be operated.
>
> This shift can be negative in some cases, such as in IPv6 parsing.
>
> This commit prevents overriding the sign bit when setting the shift
> value, which could cause instabilities when parsing IPv6 flows.
>
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Suggested-by: Alan Winkowski <walan@marvell.com>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2019-06-20 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 14:54 [PATCH net] net: mvpp2: prs: Don't override the sign bit in SRAM parser shift Maxime Chevallier
2019-06-20 8:58 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64727f68-866b-b2eb-38c9-5670efe68aaf@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=walan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).