From: Marek Vasut <marex@denx.de>
To: Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
George McCollister <george.mccollister@gmail.com>,
Tristram Ha <Tristram.Ha@microchip.com>,
Woojung Huh <woojung.huh@microchip.com>
Subject: Re: [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs
Date: Sun, 13 Oct 2019 12:53:51 +0200 [thread overview]
Message-ID: <6618b999-07ba-5c1b-60cf-6f7d7c1b3526@denx.de> (raw)
In-Reply-To: <42abfa5c-1e84-63c7-1f3d-4816d232dc98@gmail.com>
On 10/12/19 11:22 PM, Heiner Kallweit wrote:
[...]
>>> @@ -1141,13 +1174,12 @@ static struct phy_driver ksphy_driver[] = {
>>> .suspend = genphy_suspend,
>>> .resume = genphy_resume,
>>> }, {
>>> - .phy_id = PHY_ID_KSZ8795,
>>> - .phy_id_mask = MICREL_PHY_ID_MASK,
>>> .name = "Micrel KSZ8795",
>>> /* PHY_BASIC_FEATURES */
>>> .config_init = kszphy_config_init,
>>> .config_aneg = ksz8873mll_config_aneg,
>>> .read_status = ksz8873mll_read_status,
>>> + .match_phy_device = ksz8795_match_phy_device,
>>> .suspend = genphy_suspend,
>>> .resume = genphy_resume,
>>> }, {
>>>
>>
>> Patch needs to be annotated as "net-next".
>> See https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt
>>
> Except you consider this a fix, then it would require a Fixes tag and
> should be annotated "net". The question is:
> Do KSZ87xx switches misbehave currently?
Well yes they do, otherwise I won't be sending this fix.
--
Best regards,
Marek Vasut
prev parent reply other threads:[~2019-10-13 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 19:46 [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs Marek Vasut
2019-10-10 19:46 ` [PATCH V2 2/2] net: phy: micrel: Update KSZ87xx PHY name Marek Vasut
2019-10-11 5:57 ` [PATCH V2 1/2] net: phy: micrel: Discern KSZ8051 and KSZ8795 PHYs Simon Horman
2019-10-11 6:52 ` Marek Vasut
2019-10-11 9:47 ` Simon Horman
2019-10-12 20:58 ` Heiner Kallweit
2019-10-12 21:22 ` Heiner Kallweit
2019-10-13 10:53 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6618b999-07ba-5c1b-60cf-6f7d7c1b3526@denx.de \
--to=marex@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).