From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Brian Vazquez <brianvv@google.com>,
Dmitry Safonov <dima@arista.com>,
Leonard Crestez <cdleonard@gmail.com>
Subject: Re: [PATCH net] tcp: md5: fix IPv4-mapped support
Date: Tue, 26 Jul 2022 13:05:52 -0600 [thread overview]
Message-ID: <668b7bc0-6ff5-638f-6693-b7c7666f8f45@kernel.org> (raw)
In-Reply-To: <CANn89iKojuwLNCm0ZGeH+E-HjPmobLHt66_O9EhTtm00hXcwSQ@mail.gmail.com>
On 7/26/22 11:57 AM, Eric Dumazet wrote:
> Although fcnal-test.sh uses ~45 minutes currently :/
> Maybe we should make it multi netns and multi threaded to speed up things.
>
> And/or replace various "sleep 1" with more appropriate sync to make
> this faster and not flaky in case of system load.
There are currently 700+ permutations (800+ if Mike's vrf patch is only
fcnal-test). That's why the script takes a `-t TEST` argument - to only
run a subset.
nettest now has the capability for 1 command to run both client and
server in different namespaces. I have a branch that did the conversion
of fcnal-test.sh; validating the output to ensure no degradation in test
results (not just pass / fail but tests "fail" (negative tests) for the
right reason) took more time than I had. In the end it did not shorten
the test time by any significant margin so lost the motivation to wade
through the output on the before and after.
next prev parent reply other threads:[~2022-07-26 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 11:57 [PATCH net] tcp: md5: fix IPv4-mapped support Eric Dumazet
2022-07-26 15:06 ` David Ahern
2022-07-26 17:57 ` Eric Dumazet
2022-07-26 19:05 ` David Ahern [this message]
2022-07-26 17:13 ` Dmitry Safonov
2022-07-27 8:22 ` Leonard Crestez
2022-07-27 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668b7bc0-6ff5-638f-6693-b7c7666f8f45@kernel.org \
--to=dsahern@kernel.org \
--cc=brianvv@google.com \
--cc=cdleonard@gmail.com \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).