From: Jason Wang <jasowang@redhat.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, kvm list <kvm@vger.kernel.org>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version
Date: Tue, 23 Jun 2020 15:15:40 +0800 [thread overview]
Message-ID: <6715f515-3db6-1006-09dd-19464e3ff676@redhat.com> (raw)
In-Reply-To: <CAJaqyWc3C_Td_SpV97CuemkQH9vH+EL3sGgeWGE82E5gYxZNCA@mail.gmail.com>
On 2020/6/23 下午3:00, Eugenio Perez Martin wrote:
> On Tue, Jun 23, 2020 at 4:51 AM Jason Wang <jasowang@redhat.com> wrote:
>>
>> On 2020/6/23 上午12:00, Michael S. Tsirkin wrote:
>>> On Wed, Jun 17, 2020 at 11:19:26AM +0800, Jason Wang wrote:
>>>> On 2020/6/11 下午7:34, Michael S. Tsirkin wrote:
>>>>> static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq)
>>>>> {
>>>>> kfree(vq->descs);
>>>>> @@ -394,6 +400,9 @@ static long vhost_dev_alloc_iovecs(struct vhost_dev *dev)
>>>>> for (i = 0; i < dev->nvqs; ++i) {
>>>>> vq = dev->vqs[i];
>>>>> vq->max_descs = dev->iov_limit;
>>>>> + if (vhost_vq_num_batch_descs(vq) < 0) {
>>>>> + return -EINVAL;
>>>>> + }
>>>> This check breaks vdpa which set iov_limit to zero. Consider iov_limit is
>>>> meaningless to vDPA, I wonder we can skip the test when device doesn't use
>>>> worker.
>>>>
>>>> Thanks
>>> It doesn't need iovecs at all, right?
>>>
>>> -- MST
>>
>> Yes, so we may choose to bypass the iovecs as well.
>>
>> Thanks
>>
> I think that the kmalloc_array returns ZERO_SIZE_PTR for all of them
> in that case, so I didn't bother to skip the kmalloc_array parts.
> Would you prefer to skip them all and let them NULL? Or have I
> misunderstood what you mean?
I'm ok with either approach, but my understanding is that Michael wants
to skip them all.
Thanks
>
> Thanks!
>
next prev parent reply other threads:[~2020-06-23 7:15 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 11:34 [PATCH RFC v8 00/11] vhost: ring format independence Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 01/11] vhost: option to fetch descriptors through an independent struct Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 02/11] vhost: use batched get_vq_desc version Michael S. Tsirkin
2020-06-11 15:22 ` Konrad Rzeszutek Wilk
2020-06-15 12:28 ` Eugenio Perez Martin
2020-06-19 18:07 ` Eugenio Perez Martin
2020-06-19 18:25 ` Eugenio Perez Martin
2020-06-22 9:07 ` Jason Wang
2020-06-22 10:44 ` Eugenio Perez Martin
2020-06-22 15:55 ` Michael S. Tsirkin
2020-06-22 16:11 ` Eugenio Perez Martin
2020-06-22 16:29 ` Michael S. Tsirkin
2020-06-23 16:15 ` Eugenio Perez Martin
2020-07-01 10:43 ` Eugenio Perez Martin
2020-07-01 11:11 ` Michael S. Tsirkin
2020-07-01 12:56 ` Eugenio Perez Martin
2020-07-01 12:39 ` Jason Wang
2020-07-01 13:04 ` Eugenio Perez Martin
2020-07-01 14:09 ` Jason Wang
2020-07-09 16:46 ` Eugenio Perez Martin
2020-07-09 17:37 ` Michael S. Tsirkin
2020-07-10 3:56 ` Jason Wang
2020-07-10 5:39 ` Eugenio Perez Martin
2020-07-10 5:58 ` Michael S. Tsirkin
2020-07-16 17:16 ` Eugenio Perez Martin
2020-07-20 8:55 ` Jason Wang
2020-07-20 13:07 ` Eugenio Perez Martin
2020-07-20 9:27 ` Michael S. Tsirkin
2020-07-20 11:16 ` Eugenio Pérez
2020-07-20 11:45 ` Michael S. Tsirkin
2020-07-21 2:55 ` Jason Wang
2020-07-29 18:37 ` Eugenio Perez Martin
2020-07-10 6:44 ` Jason Wang
2020-06-17 3:19 ` Jason Wang
2020-06-19 17:56 ` Eugenio Perez Martin
2020-06-22 16:00 ` Michael S. Tsirkin
2020-06-23 2:51 ` Jason Wang
2020-06-23 7:00 ` Eugenio Perez Martin
2020-06-23 7:15 ` Jason Wang [this message]
2020-06-23 8:25 ` Michael S. Tsirkin
2020-06-23 15:54 ` Eugenio Perez Martin
2020-06-11 11:34 ` [PATCH RFC v8 03/11] vhost/net: pass net specific struct pointer Michael S. Tsirkin
2020-06-15 16:08 ` Eugenio Perez Martin
2020-06-11 11:34 ` [PATCH RFC v8 04/11] vhost: reorder functions Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 05/11] vhost: format-independent API for used buffers Michael S. Tsirkin
2020-06-15 16:11 ` Eugenio Perez Martin
2020-06-11 11:34 ` [PATCH RFC v8 06/11] vhost/net: convert to new API: heads->bufs Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 07/11] vhost/net: avoid iov length math Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 08/11] vhost/test: convert to the buf API Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 09/11] vhost/scsi: switch to buf APIs Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 10/11] vhost/vsock: switch to the buf API Michael S. Tsirkin
2020-06-11 11:34 ` [PATCH RFC v8 11/11] vhost: drop head based APIs Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6715f515-3db6-1006-09dd-19464e3ff676@redhat.com \
--to=jasowang@redhat.com \
--cc=eperezma@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).