From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC2EC433DF for ; Tue, 11 Aug 2020 19:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42FAE20756 for ; Tue, 11 Aug 2020 19:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="DIs9NLMS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbgHKTLF (ORCPT ); Tue, 11 Aug 2020 15:11:05 -0400 Received: from mail.efficios.com ([167.114.26.124]:47324 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgHKTLF (ORCPT ); Tue, 11 Aug 2020 15:11:05 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 529BD2CF2E0; Tue, 11 Aug 2020 15:11:04 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id hgoaOP9Sff08; Tue, 11 Aug 2020 15:11:04 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id EE8232CF534; Tue, 11 Aug 2020 15:11:03 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com EE8232CF534 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1597173063; bh=aX5VywJt4AvedzVTU+00PoSO60+jsYPIe8N+NMnuuug=; h=Date:From:To:Message-ID:MIME-Version; b=DIs9NLMS2FYpHh94Q10fjl+V6SBbPVR01oX0qwjrLguaKAqnFi0TVrLl3CXcfviqE qbH6eO/X1BD8RVhuQ12hUCpLfiGHLK0L1McWyeW8NkUMi6HHCAYZfy0dbzo9LV+FIM EOgfLWhM82MePWHTY1kZbisd2TtJPjHM2/Et0jzGOAPVbzAoqqldRa23i7Og5bOiky jzJJi+00KyxItp1zpr/72YGD3/Ul52rkQo5EVqBv39oY0RtFBC/YlhvsKuKukWeos5 igSPkh2hI/v+//AD6i+o+X2OIvPikNr5KpvY4MlsDeQOQ20vj+22LzqsMzy8KJ5Uzo Zup9/QpDcGV+Q== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CuFNI7mpAn5G; Tue, 11 Aug 2020 15:11:03 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id E29242CF351; Tue, 11 Aug 2020 15:11:03 -0400 (EDT) Date: Tue, 11 Aug 2020 15:11:03 -0400 (EDT) From: Mathieu Desnoyers To: David Ahern Cc: "David S. Miller" , Michael Jeanson , David Ahern , linux-kernel , netdev Message-ID: <699475546.4794.1597173063863.JavaMail.zimbra@efficios.com> In-Reply-To: References: <42cb74c8-9391-cf4c-9e57-7a1d464f8706@gmail.com> <20200806185121.19688-1-mjeanson@efficios.com> <20200811.102856.864544731521589077.davem@davemloft.net> Subject: Re: [PATCH] selftests: Add VRF icmp error route lookup test MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3959 (ZimbraWebClient - FF79 (Linux)/8.8.15_GA_3953) Thread-Topic: selftests: Add VRF icmp error route lookup test Thread-Index: K9OU1fUupPJcTCWW0BAtiweVmt3suA== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ----- On Aug 11, 2020, at 2:57 PM, David Ahern dsahern@gmail.com wrote: > On 8/11/20 11:28 AM, David Miller wrote: >> From: Michael Jeanson >> Date: Thu, 6 Aug 2020 14:51:21 -0400 >> >>> The objective is to check that the incoming vrf routing table is selected >>> to send an ICMP error back to the source when the ttl of a packet reaches 1 >>> while it is forwarded between different vrfs. >>> >>> The first test sends a ping with a ttl of 1 from h1 to h2 and parses the >>> output of the command to check that a ttl expired error is received. >>> >>> [This may be flaky, I'm open to suggestions of a more robust approch.] >>> >>> The second test runs traceroute from h1 to h2 and parses the output to >>> check for a hop on r1. >>> >>> Signed-off-by: Michael Jeanson >> >> This patch does not apply cleanly to the current net tree. >> > > It is also out of context since the tests fail on current net and net-next. > > The tests along with the patches that fix the problem should be sent > together. One thing I am missing before this series can be considered for upstreaming is an Acked-by of the 2 fixes for ipv4 and ipv6 from you, as maintainer of l3mdev, if you think the approach I am taking with those fixes makes sense. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com