From: Randy Dunlap <rdunlap@infradead.org>
To: Sebastien Laveze <sebastien.laveze@oss.nxp.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
yangbo.lu@nxp.com
Cc: yannick.vignon@oss.nxp.com, rui.sousa@oss.nxp.com
Subject: Re: [PATCH net-next] ptp: add vclock timestamp conversion IOCTL
Date: Mon, 27 Sep 2021 11:28:32 -0700 [thread overview]
Message-ID: <6a08ba71-02c7-638c-3a8a-b5d56a32111b@infradead.org> (raw)
In-Reply-To: <20210927093250.202131-1-sebastien.laveze@oss.nxp.com>
On 9/27/21 2:32 AM, Sebastien Laveze wrote:
> From: Seb Laveze <sebastien.laveze@nxp.com>
>
> Add an IOCTL to perform per-timestamp conversion, as an extension of the
> ptp virtual framework introduced in commit 5d43f951b1ac ("ptp: add ptp
> virtual clock driver framework").
>
> The original implementation allows binding a socket to a given virtual
> clock to perform the timestamps conversions. Commit 5d43f951b1ac ("ptp:
> add ptp virtual clock driver framework").
>
> This binding works well if the application requires all timestamps in the
> same domain but is not convenient when multiple domains need to be
> supported using a single socket.
>
> Typically, IEEE 802.1AS-2020 can be implemented using a single socket,
> the CMLDS layer using raw PHC timestamps and the domain specific
> timestamps converted in the appropriate gPTP domain using this IOCTL.
>
> Signed-off-by: Seb Laveze <sebastien.laveze@nxp.com>
> ---
> drivers/ptp/ptp_chardev.c | 24 ++++++++++++++++++++++++
> include/uapi/linux/ptp_clock.h | 1 +
> 2 files changed, 25 insertions(+)
>
> diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> index 1d108d597f66..13147d454aa8 100644
> --- a/include/uapi/linux/ptp_clock.h
> +++ b/include/uapi/linux/ptp_clock.h
> @@ -223,6 +223,7 @@ struct ptp_pin_desc {
> _IOWR(PTP_CLK_MAGIC, 17, struct ptp_sys_offset_precise)
> #define PTP_SYS_OFFSET_EXTENDED2 \
> _IOWR(PTP_CLK_MAGIC, 18, struct ptp_sys_offset_extended)
> +#define PTP_VCLOCK_CONV_TS _IOWR(PTP_CLK_MAGIC, 19, struct __kernel_timespec)
>
> struct ptp_extts_event {
> struct ptp_clock_time t; /* Time event occured. */
>
Hi,
Would someone please update Documentation/userspace-api/ioctl/ioctl-number.rst
to include
#define PTP_CLK_MAGIC '=', the name of this header file, and optional
comment or contact info, please.
thanks.
--
~Randy
prev parent reply other threads:[~2021-09-27 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 9:32 [PATCH net-next] ptp: add vclock timestamp conversion IOCTL Sebastien Laveze
2021-09-27 14:59 ` Richard Cochran
2021-09-27 16:00 ` Sebastien Laveze
2021-09-27 20:23 ` Richard Cochran
2021-09-28 11:50 ` Sebastien Laveze
2021-09-28 13:31 ` Richard Cochran
2021-09-29 15:00 ` Sebastien Laveze
2021-09-30 14:35 ` Richard Cochran
2021-10-07 13:31 ` Sebastien Laveze
2021-10-07 20:19 ` Richard Cochran
2021-10-08 7:13 ` Sebastien Laveze
2021-10-09 18:24 ` Richard Cochran
2021-10-09 18:25 ` Richard Cochran
2021-10-11 12:58 ` Richard Cochran
2021-10-12 16:14 ` Richard Cochran
2021-10-13 9:56 ` Sebastien Laveze
2021-10-13 13:10 ` Richard Cochran
2021-10-13 13:28 ` Sebastien Laveze
2021-10-13 17:54 ` Richard Cochran
2021-10-14 13:27 ` Sebastien Laveze
2021-09-27 18:28 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a08ba71-02c7-638c-3a8a-b5d56a32111b@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=rui.sousa@oss.nxp.com \
--cc=sebastien.laveze@oss.nxp.com \
--cc=yangbo.lu@nxp.com \
--cc=yannick.vignon@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).