netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Marek Vasut <marex@denx.de>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
	Tristram Ha <Tristram.Ha@microchip.com>,
	Woojung Huh <Woojung.Huh@microchip.com>
Subject: Re: [PATCH 2/5] net: dsa: microchip: Replace ksz9477_wait_vlan_ctrl_ready polling with regmap
Date: Thu, 27 Jun 2019 19:44:25 -0700	[thread overview]
Message-ID: <6b0c6d22-42df-fee5-fce6-ad5ccc67c64e@gmail.com> (raw)
In-Reply-To: <20190627215556.23768-3-marex@denx.de>



On 6/27/2019 2:55 PM, Marek Vasut wrote:
> Regmap provides polling function to poll for bits in a register. This
> function is another reimplementation of polling for bit being clear in
> a register. Replace this with regmap polling function. Moreover, inline
> the function parameters, as the function is never called with any other
> parameter values than this one.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Tristram Ha <Tristram.Ha@microchip.com>
> Cc: Woojung Huh <Woojung.Huh@microchip.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  parent reply	other threads:[~2019-06-28  2:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 21:55 [PATCH 0/5] net: dsa: microchip: Further regmap cleanups Marek Vasut
2019-06-27 21:55 ` [PATCH 1/5] net: dsa: microchip: Replace ad-hoc polling with regmap Marek Vasut
2019-06-28  0:38   ` Andrew Lunn
2019-06-28  2:43   ` Florian Fainelli
2019-06-27 21:55 ` [PATCH 2/5] net: dsa: microchip: Replace ksz9477_wait_vlan_ctrl_ready " Marek Vasut
2019-06-28  0:39   ` Andrew Lunn
2019-06-28  2:44   ` Florian Fainelli [this message]
2019-06-27 21:55 ` [PATCH 3/5] net: dsa: microchip: Replace ksz9477_wait_alu_ready " Marek Vasut
2019-06-28  0:40   ` Andrew Lunn
2019-06-27 21:55 ` [PATCH 4/5] net: dsa: microchip: Replace ksz9477_wait_alu_sta_ready " Marek Vasut
2019-06-28  0:41   ` Andrew Lunn
2019-06-27 21:55 ` [PATCH 5/5] net: dsa: microchip: Replace bit RMW " Marek Vasut
2019-06-28  0:42   ` Andrew Lunn
2019-06-28  2:25 ` [PATCH 0/5] net: dsa: microchip: Further regmap cleanups David Miller
2019-06-28 15:31 ` Vivien Didelot
2019-06-28 16:36   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b0c6d22-42df-fee5-fce6-ad5ccc67c64e@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=Tristram.Ha@microchip.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).