From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E583C433DF for ; Sat, 27 Jun 2020 22:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E287820702 for ; Sat, 27 Jun 2020 22:59:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726607AbgF0W7I (ORCPT ); Sat, 27 Jun 2020 18:59:08 -0400 Received: from neo-zeon.de ([96.90.244.226]:38838 "EHLO neo-zeon.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgF0W7I (ORCPT ); Sat, 27 Jun 2020 18:59:08 -0400 Received: from [192.168.0.55] (ukyo.nerv.lan [192.168.0.55]) (authenticated bits=0) by neo-zeon.de (8.15.2/8.15.2) with ESMTPSA id 05RMx598061828 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sat, 27 Jun 2020 15:59:05 -0700 (PDT) (envelope-from cam@neo-zeon.de) Subject: Re: [Patch net] cgroup: fix cgroup_sk_alloc() for sk_clone_lock() From: Cameron Berkenpas To: Cong Wang Cc: Roman Gushchin , Zefan Li , Linux Kernel Network Developers , Peter Geis , Lu Fengqi , =?UTF-8?Q?Dani=c3=abl_Sonck?= , Daniel Borkmann , Tejun Heo References: <20200616180352.18602-1-xiyou.wangcong@gmail.com> <141629e1-55b5-34b1-b2ab-bab6b68f0671@huawei.com> <20200618193611.GE24694@carbon.DHCP.thefacebook.com> <4f17229e-1843-5bfc-ea2f-67ebaa9056da@huawei.com> <459be87d-0272-9ea9-839a-823b01e354b6@huawei.com> <35480172-c77e-fb67-7559-04576f375ea6@huawei.com> <20200623222137.GA358561@carbon.lan> Message-ID: <6b5827a3-2832-b31d-83b6-5614a2080754@neo-zeon.de> Date: Sat, 27 Jun 2020 15:59:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The box has been up without issue for over 25 hours now. The patch seems solid. On 6/26/20 3:03 PM, Cameron Berkenpas wrote: > Box has been up for 25 minutes without issue. Probably the patch > works, but I can further confirm by tomorrow. > > On 6/26/2020 10:58 AM, Cong Wang wrote: >> On Thu, Jun 25, 2020 at 10:23 PM Cameron Berkenpas >> wrote: >>> Hello, >>> >>> Somewhere along the way I got the impression that it generally takes >>> those affected hours before their systems lock up. I'm (generally) able >>> to reproduce this issue much faster than that. Regardless, I can >>> help test. >>> >>> Are there any patches that need testing or is this all still pending >>> discussion around the  best way to resolve the issue? >> Yes. I come up with a (hopefully) much better patch in the attachment. >> Can you help to test it? You need to unapply the previous patch before >> applying this one. >> >> (Just in case of any confusion: I still believe we should check NULL on >> top of this refcnt fix. But it should be a separate patch.) >> >> Thank you! >