From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Harry Coin <hcoin@quietfountain.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net 2/4] llc: Check netns in llc_estab_match() and llc_listener_match().
Date: Tue, 18 Jul 2023 12:38:41 +0200 [thread overview]
Message-ID: <6bff83026bba89cde7c8de594f459cde612937b3.camel@redhat.com> (raw)
In-Reply-To: <20230715021338.34747-3-kuniyu@amazon.com>
On Fri, 2023-07-14 at 19:13 -0700, Kuniyuki Iwashima wrote:
> @@ -476,7 +478,8 @@ static inline bool llc_estab_match(const struct llc_sap *sap,
> */
> static struct sock *__llc_lookup_established(struct llc_sap *sap,
> struct llc_addr *daddr,
> - struct llc_addr *laddr)
> + struct llc_addr *laddr,
> + const struct net *net)
You should add 'net' to the doxygen documentation.
> {
> struct sock *rc;
> struct hlist_nulls_node *node;
[...]
> @@ -581,24 +588,26 @@ static struct sock *__llc_lookup_listener(struct llc_sap *sap,
> * Caller has to make sure local_bh is disabled.
> */
> static struct sock *llc_lookup_listener(struct llc_sap *sap,
> - struct llc_addr *laddr)
> + struct llc_addr *laddr,
> + const struct net *net)
Same here.
Thanks!
Paolo
next prev parent reply other threads:[~2023-07-18 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 2:13 [PATCH v1 net 0/4] net: Support STP on bridge in non-root netns Kuniyuki Iwashima
2023-07-15 2:13 ` [PATCH v1 net 1/4] llc: Check netns in llc_dgram_match() Kuniyuki Iwashima
2023-07-18 10:34 ` Paolo Abeni
2023-07-18 17:24 ` Kuniyuki Iwashima
2023-07-15 2:13 ` [PATCH v1 net 2/4] llc: Check netns in llc_estab_match() and llc_listener_match() Kuniyuki Iwashima
2023-07-18 10:38 ` Paolo Abeni [this message]
2023-07-15 2:13 ` [PATCH v1 net 3/4] llc: Don't drop packet from non-root netns Kuniyuki Iwashima
2023-07-15 2:13 ` [PATCH v1 net 4/4] Revert "bridge: Add extack warning when enabling STP in netns." Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bff83026bba89cde7c8de594f459cde612937b3.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=hcoin@quietfountain.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).