From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC v4 0/5] vhost: ring format independence
Date: Tue, 15 Oct 2019 10:58:13 +0800 [thread overview]
Message-ID: <6c54460c-d958-78fb-cd6e-eac97cc2c00f@redhat.com> (raw)
In-Reply-To: <20191013113940.2863-1-mst@redhat.com>
On 2019/10/13 下午7:41, Michael S. Tsirkin wrote:
> This adds infrastructure required for supporting
> multiple ring formats.
>
> The idea is as follows: we convert descriptors to an
> independent format first, and process that converting to
> iov later.
>
> The point is that we have a tight loop that fetches
> descriptors, which is good for cache utilization.
> This will also allow all kind of batching tricks -
> e.g. it seems possible to keep SMAP disabled while
> we are fetching multiple descriptors.
>
> This seems to perform exactly the same as the original
> code already based on a microbenchmark.
> Lightly tested.
> More testing would be very much appreciated.
>
> To use new code:
> echo 1 > /sys/module/vhost_test/parameters/newcode
> or
> echo 1 > /sys/module/vhost_net/parameters/newcode
>
> changes from v3:
> - fixed error handling in case of indirect descriptors
> - add BUG_ON to detect buffer overflow in case of bugs
> in response to comment by Jason Wang
> - minor code tweaks
>
> Changes from v2:
> - fixed indirect descriptor batching
> reported by Jason Wang
>
> Changes from v1:
> - typo fixes
I've just done some quick benchmark with testpmd + vhost_net txonly.
With 256 queue size, no difference but in 1024 queue size 1% regression
of PPS were found.
Thanks
>
>
> Michael S. Tsirkin (5):
> vhost: option to fetch descriptors through an independent struct
> vhost/test: add an option to test new code
> vhost: batching fetches
> vhost/net: add an option to test new code
> vhost: last descriptor must have NEXT clear
>
> drivers/vhost/net.c | 32 ++++-
> drivers/vhost/test.c | 19 ++-
> drivers/vhost/vhost.c | 328 +++++++++++++++++++++++++++++++++++++++++-
> drivers/vhost/vhost.h | 20 ++-
> 4 files changed, 385 insertions(+), 14 deletions(-)
>
prev parent reply other threads:[~2019-10-15 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 11:41 [PATCH RFC v4 0/5] vhost: ring format independence Michael S. Tsirkin
2019-10-13 11:42 ` [PATCH RFC v4 1/5] vhost: option to fetch descriptors through an independent struct Michael S. Tsirkin
2019-10-13 11:42 ` [PATCH RFC v4 2/5] vhost/test: add an option to test new code Michael S. Tsirkin
2019-10-13 11:42 ` [PATCH RFC v4 3/5] vhost: batching fetches Michael S. Tsirkin
2019-10-13 11:42 ` [PATCH RFC v4 4/5] vhost/net: add an option to test new code Michael S. Tsirkin
2019-10-13 11:42 ` [PATCH RFC v4 5/5] vhost: last descriptor must have NEXT clear Michael S. Tsirkin
2019-10-15 2:58 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c54460c-d958-78fb-cd6e-eac97cc2c00f@redhat.com \
--to=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).