From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2564AC433E6 for ; Tue, 26 Jan 2021 21:16:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF9A723109 for ; Tue, 26 Jan 2021 21:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728419AbhAZEt5 (ORCPT ); Mon, 25 Jan 2021 23:49:57 -0500 Received: from smtprelay0067.hostedemail.com ([216.40.44.67]:51872 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726523AbhAYJZP (ORCPT ); Mon, 25 Jan 2021 04:25:15 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 02DE91801EC45; Mon, 25 Jan 2021 09:24:18 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owner83_3a15a9227584 X-Filterd-Recvd-Size: 2076 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Mon, 25 Jan 2021 09:24:16 +0000 (UTC) Message-ID: <6cad823891a9bb8aa5e9bc8712896898f9747fcd.camel@perches.com> Subject: Re: [PATCH net-next 07/15] bnxt_en: log firmware debug notifications From: Joe Perches To: Michael Chan , davem@davemloft.net Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com Date: Mon, 25 Jan 2021 01:24:15 -0800 In-Reply-To: <1611558501-11022-8-git-send-email-michael.chan@broadcom.com> References: <1611558501-11022-1-git-send-email-michael.chan@broadcom.com> <1611558501-11022-8-git-send-email-michael.chan@broadcom.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2021-01-25 at 02:08 -0500, Michael Chan wrote: > From: Edwin Peer > > Firmware is capable of generating asynchronous debug notifications. > The event data is opaque to the driver and is simply logged. Debug > notifications can be enabled by turning on hardware status messages > using the ethtool msglvl interface. [] > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c [] > @@ -2072,6 +2073,13 @@ static int bnxt_async_event_process(struct bnxt *bp, >   bnxt_fw_health_readl(bp, BNXT_FW_RESET_CNT_REG); >   goto async_event_process_exit; >   } > + case ASYNC_EVENT_CMPL_EVENT_ID_DEBUG_NOTIFICATION: > + if (netif_msg_hw(bp)) { > + netdev_notice(bp->dev, > + "Received firmware debug notification, data1: 0x%x, data2: 0x%x\n", > + data1, data2); > + } netif_notice(bp, hw, bp->dev, "Received firmware debug notification, data1: 0x%x, data2: 0x%x\n", data1, data2); > + goto async_event_process_exit; >   case ASYNC_EVENT_CMPL_EVENT_ID_RING_MONITOR_MSG: { >   struct bnxt_rx_ring_info *rxr; >   u16 grp_idx;