From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC97C433B4 for ; Mon, 12 Apr 2021 07:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DE0B6121D for ; Mon, 12 Apr 2021 07:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236804AbhDLHKd (ORCPT ); Mon, 12 Apr 2021 03:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbhDLHKc (ORCPT ); Mon, 12 Apr 2021 03:10:32 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABE9C061574; Mon, 12 Apr 2021 00:10:15 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id u20so1609500wmj.0; Mon, 12 Apr 2021 00:10:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=EuL8gmDqGA0jFvgb08iY50PZ/+xeg9skTwFfVdB5qaY=; b=CDo13+cONLRw/3EJcDVE5lDZJuI8Bo7aHY3kFGkriFdRNk/tXsM11vEbZw2ZwMYQz7 YP0IxBJHahJqEOMJZTvwZNNYX7s3uSrehtyAG0xTN91vy9VZP9ADO7sw+Px9IJH9a40P cgL6kJ35aUPqQSM0e5rzipAzTm8UO5KG6yjxwLjy8xs5WfeWWN9Ff2Caun/D88lth9B6 mRYms4DDaJ1BB6GjBCX3vrEN7DWDe6hpDAYBBTvhlmB7fq/AECVFuG0/pdqbVm6wo0Cl F9Vdu3Sulb5O4Ze3apGftqRwY3qWPGRcLZYz6fGoWovpcE/kr+fyOY68YaFsNXJJxSkQ LzOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EuL8gmDqGA0jFvgb08iY50PZ/+xeg9skTwFfVdB5qaY=; b=bAuSqKCXAJYT4geIf+kqU0rmRU72/bY7FmX6cJMdpbksZuNamso/I2fidm5kV16/m1 WieSXkrCiWIqlRZxERNAB0VwFC3Kj3uKJfuBnDLf07zQdYdgaO9vbJewQFIoNlspt5uf 6KZ/p58XMhFpvTgtp0dN6148nLukQ8Wn8G1ec/u5TZzcD3eVDQvoeCBzUP0fxoOfcf9K TFkfCmJFX0ALRdhFQRIDRwegxnMY8L/eeCp//RipCgmySec4S5eBBs3z6IDSqGijxWxh WBcsvgptISysiLrqkZwRN7kSctEs2mTUSJBiNET6Fw5Ye3ZMDiHCThURpjAoJqqWu2Xk nSvA== X-Gm-Message-State: AOAM533zO/rV5r3S5Q7k0xpurVtvOX0Z5YT4s1Fya3rT5oW/EDDRxM++ Q6Y64MWd7z5f+JP6rrMXolFDomeEekE= X-Google-Smtp-Source: ABdhPJwCjIA8wploUX0BzFcnt8q32Yuf7Ez5E0+dzAquu0JDwDHqOUru0CEqdeI0TyYvuHVpbTBxig== X-Received: by 2002:a1c:6382:: with SMTP id x124mr25291677wmb.142.1618211413952; Mon, 12 Apr 2021 00:10:13 -0700 (PDT) Received: from [192.168.1.101] ([37.164.79.211]) by smtp.gmail.com with ESMTPSA id r5sm14099723wmr.15.2021.04.12.00.10.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 00:10:13 -0700 (PDT) Subject: Re: [syzbot] KMSAN: uninit-value in INET_ECN_decapsulate (2) To: syzbot , davem@davemloft.net, glider@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <00000000000083f82005bec0f1ad@google.com> From: Eric Dumazet Message-ID: <6d73d77a-5e25-0915-a0bb-3b421afa0acd@gmail.com> Date: Mon, 12 Apr 2021 09:10:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <00000000000083f82005bec0f1ad@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/30/21 3:26 PM, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 29ad81a1 arch/x86: add missing include to sparsemem.h > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=166fe481d00000 > kernel config: https://syzkaller.appspot.com/x/.config?x=b573c14b733efb1c > dashboard link: https://syzkaller.appspot.com/bug?extid=5e9c61d74e52a82b8ace > compiler: Debian clang version 11.0.1-2 > userspace arch: i386 > > Unfortunately, I don't have any reproducer for this issue yet. > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+5e9c61d74e52a82b8ace@syzkaller.appspotmail.com > > ===================================================== > BUG: KMSAN: uninit-value in __INET_ECN_decapsulate include/net/inet_ecn.h:236 [inline] > BUG: KMSAN: uninit-value in INET_ECN_decapsulate+0x329/0x1db0 include/net/inet_ecn.h:258 > CPU: 1 PID: 9058 Comm: syz-executor.1 Not tainted 5.11.0-rc7-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > Call Trace: > > __dump_stack lib/dump_stack.c:79 [inline] > dump_stack+0x21c/0x280 lib/dump_stack.c:120 > kmsan_report+0xfb/0x1e0 mm/kmsan/kmsan_report.c:118 > __msan_warning+0x5f/0xa0 mm/kmsan/kmsan_instr.c:197 > __INET_ECN_decapsulate include/net/inet_ecn.h:236 [inline] > INET_ECN_decapsulate+0x329/0x1db0 include/net/inet_ecn.h:258 > geneve_rx+0x216e/0x29d0 include/net/inet_ecn.h:304 > geneve_udp_encap_recv+0x1055/0x1340 drivers/net/geneve.c:377 > udp_queue_rcv_one_skb+0x1943/0x1af0 net/ipv4/udp.c:2095 > udp_queue_rcv_skb+0x286/0x1040 net/ipv4/udp.c:2169 > udp_unicast_rcv_skb net/ipv4/udp.c:2327 [inline] > __udp4_lib_rcv+0x3a1f/0x58f0 net/ipv4/udp.c:2396 > udp_rcv+0x5c/0x70 net/ipv4/udp.c:2567 > ip_protocol_deliver_rcu+0x572/0xc50 net/ipv4/ip_input.c:204 > ip_local_deliver_finish net/ipv4/ip_input.c:231 [inline] > NF_HOOK include/linux/netfilter.h:301 [inline] > ip_local_deliver+0x585/0x8d0 net/ipv4/ip_input.c:252 > dst_input include/net/dst.h:447 [inline] > ip_rcv_finish net/ipv4/ip_input.c:428 [inline] > NF_HOOK include/linux/netfilter.h:301 [inline] > ip_rcv+0x599/0x820 net/ipv4/ip_input.c:539 > __netif_receive_skb_one_core net/core/dev.c:5323 [inline] > __netif_receive_skb+0x1ec/0x640 net/core/dev.c:5437 > process_backlog+0x517/0xbd0 net/core/dev.c:6328 > napi_poll+0x428/0x15c0 net/core/dev.c:6806 > net_rx_action+0x34c/0xd30 net/core/dev.c:6889 > __do_softirq+0x1b9/0x715 kernel/softirq.c:343 > asm_call_irq_on_stack+0xf/0x20 > > __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] > run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] > do_softirq_own_stack+0x6e/0x90 arch/x86/kernel/irq_64.c:77 > do_softirq kernel/softirq.c:246 [inline] > __local_bh_enable_ip+0x184/0x1d0 kernel/softirq.c:196 > local_bh_enable+0x36/0x40 include/linux/bottom_half.h:32 > rcu_read_unlock_bh include/linux/rcupdate.h:737 [inline] > __dev_queue_xmit+0x3b3e/0x45c0 net/core/dev.c:4178 > dev_queue_xmit+0x4b/0x60 net/core/dev.c:4184 > packet_snd net/packet/af_packet.c:3006 [inline] > packet_sendmsg+0x8778/0x9a60 net/packet/af_packet.c:3031 > sock_sendmsg_nosec net/socket.c:652 [inline] > sock_sendmsg net/socket.c:672 [inline] > __sys_sendto+0x9ea/0xc60 net/socket.c:1975 > __do_sys_sendto net/socket.c:1987 [inline] > __se_sys_sendto+0x107/0x130 net/socket.c:1983 > __ia32_sys_sendto+0x6e/0x90 net/socket.c:1983 > do_syscall_32_irqs_on arch/x86/entry/common.c:79 [inline] > __do_fast_syscall_32+0x102/0x160 arch/x86/entry/common.c:141 > do_fast_syscall_32+0x6a/0xc0 arch/x86/entry/common.c:166 > do_SYSENTER_32+0x73/0x90 arch/x86/entry/common.c:209 > entry_SYSENTER_compat_after_hwframe+0x4d/0x5c > RIP: 0023:0xf7f84549 > Code: 03 74 c0 01 10 05 03 74 b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00 > RSP: 002b:00000000f557e5fc EFLAGS: 00000296 ORIG_RAX: 0000000000000171 > RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000020000980 > RDX: 000000000000000e RSI: 0000000000000000 RDI: 00000000200002c0 > RBP: 0000000000000014 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > > Uninit was created at: > kmsan_save_stack_with_flags mm/kmsan/kmsan.c:121 [inline] > kmsan_internal_poison_shadow+0x5c/0xf0 mm/kmsan/kmsan.c:104 > kmsan_slab_alloc+0x8d/0xe0 mm/kmsan/kmsan_hooks.c:76 > slab_alloc_node mm/slub.c:2907 [inline] > __kmalloc_node_track_caller+0xa37/0x1430 mm/slub.c:4527 > __kmalloc_reserve net/core/skbuff.c:142 [inline] > __alloc_skb+0x2f8/0xb30 net/core/skbuff.c:210 > alloc_skb include/linux/skbuff.h:1099 [inline] > alloc_skb_with_frags+0x1f3/0xc10 net/core/skbuff.c:5894 > sock_alloc_send_pskb+0xdc1/0xf90 net/core/sock.c:2348 > packet_alloc_skb net/packet/af_packet.c:2854 [inline] > packet_snd net/packet/af_packet.c:2949 [inline] > packet_sendmsg+0x6aab/0x9a60 net/packet/af_packet.c:3031 > sock_sendmsg_nosec net/socket.c:652 [inline] > sock_sendmsg net/socket.c:672 [inline] > __sys_sendto+0x9ea/0xc60 net/socket.c:1975 > __do_sys_sendto net/socket.c:1987 [inline] > __se_sys_sendto+0x107/0x130 net/socket.c:1983 > __ia32_sys_sendto+0x6e/0x90 net/socket.c:1983 > do_syscall_32_irqs_on arch/x86/entry/common.c:79 [inline] > __do_fast_syscall_32+0x102/0x160 arch/x86/entry/common.c:141 > do_fast_syscall_32+0x6a/0xc0 arch/x86/entry/common.c:166 > do_SYSENTER_32+0x73/0x90 arch/x86/entry/common.c:209 > entry_SYSENTER_compat_after_hwframe+0x4d/0x5c > ===================================================== > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > #syz fix: net: geneve: check skb is large enough for IPv4/IPv6 header