From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Andrew Lunn" <andrew@lunn.ch>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"René van Dorst" <opensource@vdorst.com>,
"SkyLake Huang" <SkyLake.Huang@mediatek.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Bartel Eerdekens" <bartel.eerdekens@constell8.be>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch
Date: Sun, 24 Mar 2024 14:45:11 +0300 [thread overview]
Message-ID: <6db6a339-e402-472f-b640-523ced553354@arinc9.com> (raw)
In-Reply-To: <ZgAQ4Ihsn6RCk7xx@shell.armlinux.org.uk>
On 24.03.2024 14:39, Russell King (Oracle) wrote:
> On Sun, Mar 24, 2024 at 12:47:08PM +0300, Arınç ÜNAL wrote:
>> I've tested with switch ports interfaces' tx-timer from 0 to 40, same
>> tx-timer for both interfaces. Loss is still there.
>
> EEE implementations tend to be a mess in the way drivers implement the
> API, so one can't at the moment rely on what ethtool says about the
> status. Sadly, this is what happens when driver authors are left to
> their own ends. :(
>
>> I suppose the MT7531 switch PHYs need calibration for EEE that is currently
>> missing from the mediatek-ge driver.
>
> EEE is quite simple from the software point of view. There is software
> negotiation of the modules that EEE supports, and then there is are
> one or more timers that affect the behaviour of EEE. The LPI timer is
> "how long the link needs to be idle for before _this_ end signals that
> it _can_ enter low power state". The link only enters low power state
> when *both* ends of the link signal that they can enter low power
> state.
>
> What calibration would be necessary?
Check out mt798x_phy_eee() on drivers/net/phy/mediatek-ge-soc.c.
Arınç
next prev parent reply other threads:[~2024-03-24 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <=?utf-8?q?=3C20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v?=>
2024-03-19 18:25 ` [PATCH 0/3] Fix EEE support for MT7531 and MT7988 SoC switch Daniel Golle
2024-03-19 18:46 ` Arınç ÜNAL
2024-03-19 19:38 ` Andrew Lunn
2024-03-19 20:04 ` Arınç ÜNAL
2024-03-19 20:26 ` Daniel Golle
2024-03-19 21:16 ` Arınç ÜNAL
2024-03-19 21:31 ` Florian Fainelli
2024-03-21 16:09 ` Arınç ÜNAL
2024-03-21 16:31 ` Florian Fainelli
2024-03-24 9:47 ` Arınç ÜNAL
2024-03-24 11:39 ` Russell King (Oracle)
2024-03-24 11:45 ` Arınç ÜNAL [this message]
[not found] <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v1-0-3f17226344e8@arinc9.com>
2024-03-20 8:10 ` Arınç ÜNAL
2024-03-20 11:08 ` Daniel Golle
2024-03-20 15:03 ` Arınç ÜNAL
[not found] <65f7f17d.050a0220.3c75a.cde3SMTPIN_ADDED_BROKEN@mx.google.com>
2024-03-18 12:57 ` Florian Fainelli
2024-03-18 14:03 ` Arınç ÜNAL
2024-03-18 18:01 ` Konstantin Ryabitsev
2024-03-19 16:03 ` Konstantin Ryabitsev
2024-03-19 18:31 ` Arınç ÜNAL
2024-03-18 7:46 Arınç ÜNAL via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db6a339-e402-472f-b640-523ced553354@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bartel.eerdekens@constell8.be \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).