From: David Ahern <dsahern@gmail.com>
To: Guillaume Nault <gnault@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [RFC iproute2] tos: interpret ToS in natural numeral system
Date: Wed, 16 Feb 2022 18:52:43 -0700 [thread overview]
Message-ID: <6dbf4b79-70d4-ed6c-0fd4-c393ab1c90b3@gmail.com> (raw)
In-Reply-To: <20220216222352.GA3432@pc-4.home>
On 2/16/22 3:23 PM, Guillaume Nault wrote:
> On Wed, Feb 16, 2022 at 11:42:05AM -0800, Jakub Kicinski wrote:
>> Silently forcing a base numeral system is very painful for users.
>> ip currently interprets tos 10 as 0x10. Imagine user's bash script
>> does:
>>
>> .. tos $((TOS * 2)) ..
>>
>> or any numerical operation on the ToS.
>>
>> This patch breaks existing scripts if they expect 10 to be 0x10.
>
> I agree that we shouldn't have forced base 16 in the first place.
> But after so many years I find it a bit dangerous to change that.
I agree. In this case the change in behavior will not be very obvious
and could lead to confusion. I think this is something we have to live with.
>
> What about just printing a warning when the value isn't prefixed with
> '0x'? Something like (completely untested):
>
> @@ -535,6 +535,12 @@ int rtnl_dsfield_a2n(__u32 *id, const char *arg)
> if (!end || end == arg || *end || res > 255)
> return -1;
> *id = res;
> +
> + if (strncmp("0x", arg, 2))
> + fprintf(stderr,
> + "Warning: dsfield and tos parameters are interpreted as hexadecimal values\n"
> + "Use 'dsfield 0x%02x' to avoid this message\n", res);
> +
> return 0;
> }
That seems reasonable to me to let users know of this behavior.
>
>
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> --
>> I get the feeling this was discussed in the past.
>>
>> Also there's more:
>>
>> devlink/devlink.c: val = strtoull(str, &endptr, 10);
>> devlink/devlink.c: val = strtoul(str, &endptr, 10);
>> devlink/devlink.c: val = strtoul(str, &endptr, 10);
>> devlink/devlink.c: val = strtoul(str, &endptr, 10);
I think the devlink ones all check out. I think those functions can be
updated to use get_uNN from lib/utils.c.
>> lib/utils.c: res = strtoul(arg, &ptr, base);
This is get_unsigned and those users outside of tc look ok.
>> lib/utils.c: n = strtoul(cp, &endp, 16);
ipv6 address conversion which is hex based.
>> lib/utils.c: tmp = strtoul(tmpstr, &endptr, 16);
>> lib/utils.c: tmp = strtoul(arg + i * 3, &endptr, 16);
both of these are valid hex conversions
>> misc/lnstat_util.c: unsigned long f = strtoul(ptr, &ptr, 16);
>> tc/f_u32.c: htid = strtoul(str, &tmp, 16);
>> tc/f_u32.c: hash = strtoul(str, &tmp, 16);
>> tc/f_u32.c: nodeid = strtoul(str, &tmp, 16);
>> tc/tc_util.c: maj = strtoul(str, &p, 16);
>> tc/tc_util.c: maj = strtoul(str, &p, 16);
>> tc/tc_util.c: min = strtoul(str, &p, 16);
>
> After a very quick look, many of these seem to make sense though. For
> example lnstat_util.c parses output from /proc, hexstring_a2n() is used
> by ipmacsec.c to parse crypto keys, etc.
>
> But I agree that we should probably audit the strtol() (and variants)
> that don't use base 0.
Added Jamal and Cong for the tc references. Hopefully those are
documented to be hex values.
next prev parent reply other threads:[~2022-02-17 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:42 [RFC iproute2] tos: interpret ToS in natural numeral system Jakub Kicinski
2022-02-16 22:23 ` Guillaume Nault
2022-02-16 22:44 ` David Laight
2022-02-17 11:18 ` Guillaume Nault
2022-02-17 1:52 ` David Ahern [this message]
2022-02-17 2:40 ` Jakub Kicinski
2022-02-17 19:12 ` Stephen Hemminger
2022-02-17 19:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dbf4b79-70d4-ed6c-0fd4-c393ab1c90b3@gmail.com \
--to=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=jhs@mojatatu.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).