From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing and aggregation type Date: Sun, 20 Aug 2017 14:18:03 -0400 Message-ID: <6dd2e0b7-51ec-18a3-07fb-3952a114b89a@mojatatu.com> References: <1503120931-30092-1-git-send-email-subashab@codeaurora.org> <1503120931-30092-2-git-send-email-subashab@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Subash Abhinov Kasiviswanathan , netdev@vger.kernel.org, davem@davemloft.net, fengguang.wu@intel.com, dcbw@redhat.com, jiri@resnulli.us, stephen@networkplumber.org, David.Laight@ACULAB.COM, marcel@holtmann.org Return-path: Received: from mail-it0-f65.google.com ([209.85.214.65]:36734 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbdHTSSG (ORCPT ); Sun, 20 Aug 2017 14:18:06 -0400 Received: by mail-it0-f65.google.com with SMTP id 190so398473itx.3 for ; Sun, 20 Aug 2017 11:18:06 -0700 (PDT) In-Reply-To: <1503120931-30092-2-git-send-email-subashab@codeaurora.org> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 17-08-19 01:35 AM, Subash Abhinov Kasiviswanathan wrote: > Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This > is needed for receiving data in the MAP protocol like RMNET. This is > not an officially registered ID. > > Signed-off-by: Subash Abhinov Kasiviswanathan > --- > include/uapi/linux/if_ether.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h > index 5bc9bfd..e80b03f 100644 > --- a/include/uapi/linux/if_ether.h > +++ b/include/uapi/linux/if_ether.h > @@ -104,7 +104,9 @@ > #define ETH_P_QINQ3 0x9300 /* deprecated QinQ VLAN [ NOT AN OFFICIALLY REGISTERED ID ] */ > #define ETH_P_EDSA 0xDADA /* Ethertype DSA [ NOT AN OFFICIALLY REGISTERED ID ] */ > #define ETH_P_AF_IUCV 0xFBFB /* IBM af_iucv [ NOT AN OFFICIALLY REGISTERED ID ] */ > - > +#define ETH_P_MAP 0xDA1A /* Multiplexing and Aggregation Protocol > + * NOT AN OFFICIALLY REGISTERED ID ] You cant just arbitrarly assign yourself an ethertype. The IEEE may never issue you one - and if they do, it will likely not be the one you want i.e above. If there is a way for you to make this a config option that is not hardcoded to some default value then that would be the best approach to take. cheers, jamal