From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4170C31E5E for ; Tue, 18 Jun 2019 21:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8480220863 for ; Tue, 18 Jun 2019 21:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730709AbfFRVCi (ORCPT ); Tue, 18 Jun 2019 17:02:38 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:48164 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730102AbfFRVCi (ORCPT ); Tue, 18 Jun 2019 17:02:38 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hdLFE-0007LA-Ng; Tue, 18 Jun 2019 23:02:20 +0200 Message-ID: <6e7f0fb2f85d5062a9e23d37c47d311e10aa4624.camel@sipsolutions.net> Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver From: Johannes Berg To: Arnd Bergmann Cc: Alex Elder , abhishek.esse@gmail.com, Ben Chan , Bjorn Andersson , cpratapa@codeaurora.org, David Miller , Dan Williams , DTML , Eric Caruso , evgreen@chromium.org, Ilias Apalodimas , Linux ARM , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , linux-soc@vger.kernel.org, Networking , Subash Abhinov Kasiviswanathan , syadagir@codeaurora.org Date: Tue, 18 Jun 2019 23:02:18 +0200 In-Reply-To: (sfid-20190618_225543_624686_3B7D51E7) References: <380a6185-7ad1-6be0-060b-e6e5d4126917@linaro.org> <066e9b39f937586f0f922abf801351553ec2ba1d.camel@sipsolutions.net> <613cdfde488eb23d7207c7ba6258662702d04840.camel@sipsolutions.net> (sfid-20190618_225543_624686_3B7D51E7) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2019-06-18 at 22:55 +0200, Arnd Bergmann wrote: > On Tue, Jun 18, 2019 at 10:36 PM Johannes Berg > wrote: > > > > On Tue, 2019-06-18 at 21:59 +0200, Arnd Bergmann wrote: > > > > > > From my understanding, the ioctl interface would create the lower > > > netdev after talking to the firmware, and then user space would use > > > the rmnet interface to create a matching upper-level device for that. > > > This is an artifact of the strong separation of ipa and rmnet in the > > > code. > > > > Huh. But if rmnet has muxing, and IPA supports that, why would you ever > > need multiple lower netdevs? > > From my reading of the code, there is always exactly a 1:1 relationship > between an rmnet netdev an an ipa netdev. rmnet does the encapsulation/ > decapsulation of the qmap data and forwards it to the ipa netdev, > which then just passes data through between a hardware queue and > its netdevice. I'll take your word for it. Seems very odd, given that the whole point of the QMAP header seems to be ... muxing? > [side note: on top of that, rmnet also does "aggregation", which may > be a confusing term that only means transferring multiple frames > at once] Right, but it's not all that much interesting in the context of this discussion. > Sure, I definitely understand what you mean, and I agree that would > be the right way to do it. All I said is that this is not how it was done > in rmnet (this was again my main concern about the rmnet design > after I learned it was required for ipa) ;-) :-) Well, I guess though if the firmware wants us to listen to those on/off messages we'll have to do that one way or the other. Oh. Maybe it's just *because* rmnet is layered on top, and thus you fundamentally cannot do flow control the way I described - not because you have multiple session on the same hardware ring, but because you abstracted the hardware ring away too much ... johannes