From: Hemant Kumar <hemantk@codeaurora.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH] bus: mhi: Add inbound buffers allocation flag
Date: Fri, 8 Jan 2021 20:37:20 -0800 [thread overview]
Message-ID: <6e812726-d7e2-412a-940c-53cdd361c5aa@codeaurora.org> (raw)
In-Reply-To: <20210108153032.GC32678@work>
On 1/8/21 7:30 AM, Manivannan Sadhasivam wrote:
> On Fri, Jan 08, 2021 at 03:01:59PM +0100, Loic Poulain wrote:
>> Hi Mani,
>>
>> On Fri, 8 Jan 2021 at 14:44, Manivannan Sadhasivam <
>> manivannan.sadhasivam@linaro.org> wrote:
>>
>>> On Wed, Jan 06, 2021 at 02:43:43PM +0100, Loic Poulain wrote:
>>>> Currently, the MHI controller driver defines which channels should
>>>> have their inbound buffers allocated and queued. But ideally, this is
>>>> something that should be decided by the MHI device driver instead,
>>>
>>> We call them, "MHI client drivers"
>>>
>>
>> I'll fix that.
>>
>>
>>>> which actually deals with that buffers.
>>>>
>>>> Add a flag parameter to mhi_prepare_for_transfer allowing to specify
>>>> if buffers have to be allocated and queued by the MHI stack.
>>>>
>>>> Keep auto_queue flag for now, but should be removed at some point.
>>>>
>>>> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
>>>> ---
>>>> drivers/bus/mhi/core/internal.h | 2 +-
>>>> drivers/bus/mhi/core/main.c | 11 ++++++++---
>>>> drivers/net/mhi_net.c | 2 +-
>>>> include/linux/mhi.h | 12 +++++++++++-
>>>> net/qrtr/mhi.c | 2 +-
>>>> 5 files changed, 22 insertions(+), 7 deletions(-)
>>>>
>>>
>>> [...]
>>>
>>>> diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
>>>> index fa41d8c..b7f7f2e 100644
>>>> --- a/drivers/net/mhi_net.c
>>>> +++ b/drivers/net/mhi_net.c
>>>> @@ -265,7 +265,7 @@ static int mhi_net_probe(struct mhi_device *mhi_dev,
>>>> u64_stats_init(&mhi_netdev->stats.tx_syncp);
>>>>
>>>> /* Start MHI channels */
>>>> - err = mhi_prepare_for_transfer(mhi_dev);
>>>> + err = mhi_prepare_for_transfer(mhi_dev, 0);
>>>
>>> Eventhough I'd like Hemant to comment on this patch, AFAIU this looks to
>>> me a controller dependent behaviour. The controller should have the
>>> information whether a particular channel can auto queue or not then the
>>> client driver can be agnostic.
I am fine with his change, and agree that MHI client driver should be
able to make the decision.
Having said that, can we merge this on top of UCI :).
[..]
Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2021-01-09 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 13:43 [PATCH] bus: mhi: Add inbound buffers allocation flag Loic Poulain
2021-01-08 13:44 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi9tUUzf0hLwLUBqB=+eGQS-eNP8NtnMF-iS1ZqUfautuw@mail.gmail.com>
2021-01-08 15:30 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi_+wHo4q1BQScXALRaTAqNh0zxsgLsri364NvTP1h+6WQ@mail.gmail.com>
2021-01-08 17:17 ` Manivannan Sadhasivam
2021-01-09 4:37 ` Hemant Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e812726-d7e2-412a-940c-53cdd361c5aa@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).