archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <>
To: Jakub Sitnicki <>,
Cc: John Fastabend <>,
	Marek Majkowski <>
Subject: Re: [PATCH net] sk_msg: Always cancel strp work before freeing the psock
Date: Tue, 29 Jan 2019 00:24:43 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 01/28/2019 10:13 AM, Jakub Sitnicki wrote:
> Despite having stopped the parser, we still need to deinitialize it by
> calling strp_done so that it cancels its work. Otherwise the worker
> thread can run after we have freed the parser, and attempt to access its
> workqueue resulting in a use-after-free:
> Reported-by: Marek Majkowski <>
> Link:
> Signed-off-by: Jakub Sitnicki <>

Applied, thanks!

      parent reply	other threads:[~2019-01-28 23:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28  9:13 Jakub Sitnicki
2019-01-28 20:35 ` Song Liu
2019-01-28 23:24 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH net] sk_msg: Always cancel strp work before freeing the psock' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).