From: Daniel Borkmann <daniel@iogearbox.net>
To: Jakub Sitnicki <jakub@cloudflare.com>, netdev@vger.kernel.org
Cc: John Fastabend <john.fastabend@gmail.com>,
Marek Majkowski <marek@cloudflare.com>
Subject: Re: [PATCH net] sk_msg: Always cancel strp work before freeing the psock
Date: Tue, 29 Jan 2019 00:24:43 +0100 [thread overview]
Message-ID: <6f32f383-a9ba-7e1f-2c65-3546c833a4c1@iogearbox.net> (raw)
In-Reply-To: <20190128091335.20908-1-jakub@cloudflare.com>
On 01/28/2019 10:13 AM, Jakub Sitnicki wrote:
> Despite having stopped the parser, we still need to deinitialize it by
> calling strp_done so that it cancels its work. Otherwise the worker
> thread can run after we have freed the parser, and attempt to access its
> workqueue resulting in a use-after-free:
>
[...]
> Reported-by: Marek Majkowski <marek@cloudflare.com>
> Link: https://lore.kernel.org/netdev/CAJPywTLwgXNEZ2dZVoa=udiZmtrWJ0q5SuBW64aYs0Y1khXX3A@mail.gmail.com
> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
Applied, thanks!
prev parent reply other threads:[~2019-01-28 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 9:13 [PATCH net] sk_msg: Always cancel strp work before freeing the psock Jakub Sitnicki
2019-01-28 20:35 ` Song Liu
2019-01-28 23:24 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f32f383-a9ba-7e1f-2c65-3546c833a4c1@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=marek@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).