From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34866C31E5D for ; Tue, 18 Jun 2019 19:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D5B62084B for ; Tue, 18 Jun 2019 19:44:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="R4uJclZH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730468AbfFRToR (ORCPT ); Tue, 18 Jun 2019 15:44:17 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:14507 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725909AbfFRToR (ORCPT ); Tue, 18 Jun 2019 15:44:17 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 18 Jun 2019 12:44:16 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 18 Jun 2019 12:44:16 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 18 Jun 2019 12:44:16 -0700 Received: from [10.26.11.81] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 18 Jun 2019 19:44:13 +0000 Subject: Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic From: Jon Hunter To: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" CC: Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-tegra References: <6226d6a0de5929ed07d64b20472c52a86e71383d.1560266175.git.joabreu@synopsys.com> <78EB27739596EE489E55E81C33FEC33A0B9C8D6E@DE02WEMBXB.internal.synopsys.com> <26cfaeff-a310-3b79-5b57-fd9c93bd8929@nvidia.com> <78EB27739596EE489E55E81C33FEC33A0B9C8DD9@DE02WEMBXB.internal.synopsys.com>

Message-ID: <6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com> Date: Tue, 18 Jun 2019 20:44:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1560887056; bh=PwZarqBwDAlCSx+BZ96mh7Tp8BKOluB88TjkXU/xKMw=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=R4uJclZHP4uqM8KUkkbfj3B9imly/wEhiSJ+rvRgRqF3AJa6y9N1BU6AXqkxxAAN1 mNyagoJzU6qaXcWda8VeAbmZLFnX75S6fAuQQHcvCk3gd2EShrvgg1Z+bjMMc4B8rG FJu/aAOR/Exkzc6LDxCm9bJ8mUYHGeMtsrFgMASjIzGq+V35FV3nybMf5El3fm2l2c a9IXt/mfbR5HkwAzEORHNYj/z0kXPVAYYDufwAP4cL4C61y+gIAHwH/PXO/UTUq1YL 0SH0j61GFIRBnjbVDvzrPYmzQexp/GLub91IIoZcWbLe8IdIUEPvNW+KAN/m6Wuzle rvnwW7P2e7h7Q== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 18/06/2019 16:20, Jon Hunter wrote: > > On 18/06/2019 11:18, Jon Hunter wrote: >> >> On 18/06/2019 10:46, Jose Abreu wrote: >>> From: Jon Hunter >>> >>>> I am not certain but I don't believe so. We are using a static IP address >>>> and mounting the root file-system via NFS when we see this ... >>> >>> Can you please add a call to napi_synchronize() before every >>> napi_disable() calls, like this: >>> >>> if (queue < rx_queues_cnt) { >>> napi_synchronize(&ch->rx_napi); >>> napi_disable(&ch->rx_napi); >>> } >>> >>> if (queue < tx_queues_cnt) { >>> napi_synchronize(&ch->tx_napi); >>> napi_disable(&ch->tx_napi); >>> } >>> >>> [ I can send you a patch if you prefer ] >> >> Yes I can try this and for completeness you mean ... >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> index 4ca46289a742..d4a12cb64d8e 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> @@ -146,10 +146,15 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv) >> for (queue = 0; queue < maxq; queue++) { >> struct stmmac_channel *ch = &priv->channel[queue]; >> >> - if (queue < rx_queues_cnt) >> + if (queue < rx_queues_cnt) { >> + napi_synchronize(&ch->rx_napi); >> napi_disable(&ch->rx_napi); >> - if (queue < tx_queues_cnt) >> + } >> + >> + if (queue < tx_queues_cnt) { >> + napi_synchronize(&ch->tx_napi); >> napi_disable(&ch->tx_napi); >> + } >> } >> } > > So good news and bad news ... > > The good news is that the above change does fix the initial crash > I am seeing. However, even with this change applied on top of > -next, it is still dying somewhere else and so there appears to > be a second issue. Further testing has shown that actually this does NOT resolve the issue and I am still seeing the crash. Sorry for the false-positive. Jon -- nvpublic