From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] nfc: hci: pass callback data param as pointer in nci_request()
Date: Fri, 30 Jul 2021 16:03:27 +0200 [thread overview]
Message-ID: <6f609952-cf76-58f9-1917-f06f3f376843@canonical.com> (raw)
In-Reply-To: <20210730065830.547df546@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 30/07/2021 15:58, Jakub Kicinski wrote:
> On Fri, 30 Jul 2021 15:56:19 +0200 Krzysztof Kozlowski wrote:
>> On 30/07/2021 15:49, Jakub Kicinski wrote:
>>> This generates a bunch of warnings:
>>>
>>> net/nfc/nci/core.c:381:51: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:388:50: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:494:57: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:520:65: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:570:44: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:815:34: warning: Using plain integer as NULL pointer
>>> net/nfc/nci/core.c:856:50: warning: Using plain integer as NULL pointer
>>
>> Indeed. Not that code before was better - the logic was exactly the
>> same. I might think more how to avoid these and maybe pass pointer to
>> stack value (like in other cases).
>>
>> The 7/8 and 8/8 could be skipped in such case.
>
> We don't usually take parts of series, would you mind resending first 6
> or respinning with the warnings addressed?
Sure, no problem.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-07-30 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 6:56 [PATCH v2 0/8] nfc: constify pointed data - missed part Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 1/8] nfc: mrvl: correct nfcmrvl_spi_parse_dt() device_node argument Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 2/8] nfc: annotate af_nfc_exit() as __exit Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 3/8] nfc: hci: annotate nfc_llc_init() as __init Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 4/8] nfc: constify several pointers to u8, char and sk_buff Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 5/8] nfc: constify local pointer variables Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 6/8] nfc: nci: constify several pointers to u8, sk_buff and other structs Krzysztof Kozlowski
2021-07-30 6:56 ` [PATCH v2 7/8] nfc: hci: pass callback data param as pointer in nci_request() Krzysztof Kozlowski
2021-07-30 13:49 ` Jakub Kicinski
2021-07-30 13:56 ` Krzysztof Kozlowski
2021-07-30 13:58 ` Jakub Kicinski
2021-07-30 14:03 ` Krzysztof Kozlowski [this message]
2021-07-30 6:56 ` [PATCH v2 8/8] nfc: hci: cleanup unneeded spaces Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f609952-cf76-58f9-1917-f06f3f376843@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).