From: tanhuazhong <tanhuazhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>, <tanxiaofei@huawei.com>
Subject: Re: [PATCH net-next 01/12] net: hns3: log detail error info of ROCEE ECC and AXI errors
Date: Fri, 7 Jun 2019 08:29:08 +0800 [thread overview]
Message-ID: <705efc0c-eada-98d0-d6a8-b92eca0f09f9@huawei.com> (raw)
In-Reply-To: <20190606.103621.340824426867229259.davem@davemloft.net>
On 2019/6/7 1:36, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@huawei.com>
> Date: Thu, 6 Jun 2019 16:20:56 +0800
>
>> +static int hclge_log_rocee_axi_error(struct hclge_dev *hdev)
>> +{
> ...
>> + ret = hclge_cmd_send(&hdev->hw, &desc[0], 3);
>> + if (ret) {
>> + dev_err(dev, "failed(%d) to query ROCEE AXI error sts\n", ret);
>> + return ret;
>> + }
> ...
>> + ret = hclge_log_rocee_axi_error(hdev);
>> + if (ret) {
>> + dev_err(dev, "failed(%d) to process axi error\n", ret);
>
> You log the error twice which is unnecessary.
>
ok, thanks.
> .
>
next prev parent reply other threads:[~2019-06-07 0:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 8:20 [PATCH net-next 00/12] net: hns3: some code optimizations & cleanups & bugfixes Huazhong Tan
2019-06-06 8:20 ` [PATCH net-next 01/12] net: hns3: log detail error info of ROCEE ECC and AXI errors Huazhong Tan
2019-06-06 17:36 ` David Miller
2019-06-07 0:29 ` tanhuazhong [this message]
2019-06-06 8:20 ` [PATCH net-next 02/12] net: hns3: fix wrong size of mailbox responding data Huazhong Tan
2019-06-06 8:20 ` [PATCH net-next 03/12] net: hns3: make HW GRO handling compliant with SW GRO Huazhong Tan
2019-06-06 8:20 ` [PATCH net-next 04/12] net: hns3: replace numa_node_id with numa_mem_id for buffer reusing Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 05/12] net: hns3: refactor hns3_get_new_int_gl function Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 06/12] net: hns3: trigger VF reset if a VF has an over_8bd_nfe_err Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 07/12] net: hns3: Delete the redundant user nic codes Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 08/12] net: hns3: small changes for magic numbers Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 09/12] net: hns3: use macros instead of " Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 10/12] net: hns3: refactor PF/VF RSS hash key configuration Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 11/12] net: hns3: some modifications to simplify and optimize code Huazhong Tan
2019-06-06 8:21 ` [PATCH net-next 12/12] net: hns3: fix some coding style issues Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=705efc0c-eada-98d0-d6a8-b92eca0f09f9@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).