From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, cai@lca.pw
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ipv4: fix a RCU-list lock in fib_triestat_seq_show
Date: Thu, 26 Mar 2020 22:41:40 -0700 [thread overview]
Message-ID: <707e70a3-59f7-bc11-fd11-c5409e39c476@gmail.com> (raw)
In-Reply-To: <20200326.202714.1221436401038064762.davem@davemloft.net>
On 3/26/20 8:27 PM, David Miller wrote:
> From: Qian Cai <cai@lca.pw>
> Date: Wed, 25 Mar 2020 18:01:00 -0400
>> Fix it by adding a pair of rcu_read_lock/unlock() and use
>> cond_resched_rcu() to avoid the situation where walking of a large
>> number of items may prevent scheduling for a long time.
>>
>> Signed-off-by: Qian Cai <cai@lca.pw>
>
> Eric, please review.
>
Patch looks good to me, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2020-03-27 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 22:01 [PATCH v2] ipv4: fix a RCU-list lock in fib_triestat_seq_show Qian Cai
2020-03-27 3:27 ` David Miller
2020-03-27 5:41 ` Eric Dumazet [this message]
2020-03-30 4:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=707e70a3-59f7-bc11-fd11-c5409e39c476@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=cai@lca.pw \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).