netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics
Date: Thu, 5 Sep 2019 10:48:01 +0800	[thread overview]
Message-ID: <70ae3f79-0c57-97d4-ebec-1378782605c8@oracle.com> (raw)
In-Reply-To: <20190904.152218.250246841354408872.davem@davemloft.net>


On 2019/9/5 6:22, David Miller wrote:
> From: Zhu Yanjun <yanjun.zhu@oracle.com>
> Date: Sun,  1 Sep 2019 03:26:13 -0400
>
>> +static inline void nv_get_stats(int cpu, struct fe_priv *np,
>> +				struct rtnl_link_stats64 *storage)
>   ...
>> +static inline void rx_missing_handler(u32 flags, struct fe_priv *np)
>> +{
> Never use the inline keyword in foo.c files, let the compiler decide.

Thanks a lot for your advice. I will pay attention to the usage of 
inline in the

source code.

If you agree, I will send V3 about this soon.

Zhu Yanjun

>

  reply	other threads:[~2019-09-05  2:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01  7:26 [PATCHv2 0/1] Fix deadlock problem and make performance better Zhu Yanjun
2019-09-01  7:26 ` [PATCHv2 1/1] forcedeth: use per cpu to collect xmit/recv statistics Zhu Yanjun
2019-09-04 22:22   ` David Miller
2019-09-05  2:48     ` Zhu Yanjun [this message]
2019-09-05  6:13       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70ae3f79-0c57-97d4-ebec-1378782605c8@oracle.com \
    --to=yanjun.zhu@oracle.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).