[PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

[PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

[Gustavo A. R. Silva]

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 net/rxrpc/af_rxrpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index 41671af6b33f..2b5f89713e36 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
 	switch (rx->sk.sk_state) {
 	case RXRPC_UNBOUND:
 		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
+		break;
 	case RXRPC_CLIENT_UNBOUND:
 	case RXRPC_CLIENT_BOUND:
 		break;
-- 
2.27.0

Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

[Gustavo A. R. Silva]

Hi all,

Friendly ping: who can take this, please?

Thanks
--
Gustavo

On 3/5/21 03:19, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>  net/rxrpc/af_rxrpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
> index 41671af6b33f..2b5f89713e36 100644
> --- a/net/rxrpc/af_rxrpc.c
> +++ b/net/rxrpc/af_rxrpc.c
> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>  	switch (rx->sk.sk_state) {
>  	case RXRPC_UNBOUND:
>  		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
> +		break;
>  	case RXRPC_CLIENT_UNBOUND:
>  	case RXRPC_CLIENT_BOUND:
>  		break;
> 

Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

[Jeffrey E Altman]

[-- Attachment #1.1.1: Type: text/plain, Size: 542 bytes --]

On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

This change looks good to me.  Although I would also be happy with a 
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <jaltman@auristor.com>


[-- Attachment #1.1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]

begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

[Gustavo A. R. Silva]

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,
> 
> Friendly ping: who can take this, please?
> 
> Thanks
> --
> Gustavo
> 
> On 3/5/21 03:19, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>>  net/rxrpc/af_rxrpc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
>> index 41671af6b33f..2b5f89713e36 100644
>> --- a/net/rxrpc/af_rxrpc.c
>> +++ b/net/rxrpc/af_rxrpc.c
>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>>  	switch (rx->sk.sk_state) {
>>  	case RXRPC_UNBOUND:
>>  		rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
>> +		break;
>>  	case RXRPC_CLIENT_UNBOUND:
>>  	case RXRPC_CLIENT_BOUND:
>>  		break;
>>