From: Eric Dumazet <eric.dumazet@gmail.com>
To: Bui Quang Minh <minhquangbui99@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, willemb@google.com, pabeni@redhat.com,
avagin@gmail.com, alexander@mihalicyn.com,
lesedorucalin01@gmail.com
Subject: Re: [PATCH v2 1/2] udp: UDP socket send queue repair
Date: Wed, 11 Aug 2021 18:14:30 +0200 [thread overview]
Message-ID: <721a2e32-c930-ad6b-5055-631b502ed11b@gmail.com> (raw)
In-Reply-To: <20210811154557.6935-1-minhquangbui99@gmail.com>
On 8/11/21 5:45 PM, Bui Quang Minh wrote:
> In this patch, I implement UDP_REPAIR sockoption and a new path in
> udp_recvmsg for dumping the corked packet in UDP socket's send queue.
>
> A userspace program can use recvmsg syscall to get the packet's data and
> the msg_name information of the packet. Currently, other related
> information in inet_cork that are set in cmsg are not dumped.
>
> While working on this, I was aware of Lese Doru Calin's patch and got some
> ideas from it.
What is the use case for this feature, adding a test in UDP fast path ?
CORKed UDP is hardly used nowadays.
IMO, TCP_REPAIR hijacking standard system calls was a design error,
we should have added new system calls.
next prev parent reply other threads:[~2021-08-11 16:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:45 [PATCH v2 1/2] udp: UDP socket send queue repair Bui Quang Minh
2021-08-11 16:14 ` Eric Dumazet [this message]
2021-08-12 13:46 ` Bui Quang Minh
2021-08-12 15:51 ` Eric Dumazet
2021-08-13 11:08 ` Bui Quang Minh
2021-08-13 13:00 ` David Laight
2021-08-17 16:22 ` avagin
2021-08-16 14:35 ` Willem de Bruijn
2021-08-16 14:38 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721a2e32-c930-ad6b-5055-631b502ed11b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=alexander@mihalicyn.com \
--cc=avagin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=lesedorucalin01@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minhquangbui99@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).