From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jakub.kicinski@netronome.com,
saeedm@mellanox.com, leon@kernel.org, tariqt@mellanox.com,
ayal@mellanox.com, vladbu@mellanox.com, michaelgur@mellanox.com,
moshe@mellanox.com, mlxsw@mellanox.com
Subject: Re: [patch net-next 0/4] net: allow per-net notifier to follow netdev into namespace
Date: Fri, 20 Dec 2019 11:30:22 -0700 [thread overview]
Message-ID: <72587b16-d459-aa6e-b813-cf14b4118b0c@gmail.com> (raw)
In-Reply-To: <20191220123542.26315-1-jiri@resnulli.us>
On 12/20/19 5:35 AM, Jiri Pirko wrote:
> However if netdev can change namespace, per-net notifier cannot be used.
> Introduce dev_net variant that is basically per-net notifier with an
> extension that re-registers the per-net notifier upon netdev namespace
> change. Basically the per-net notifier follows the netdev into
> namespace.
This is getting convoluted.
If the driver wants notifications in a new namespace, then it should
register for notifiers in the new namespace. The info for
NETDEV_UNREGISTER event could indicate the device is getting moved to a
new namespace and the driver register for notifications in the new
namespace. If the drivers are trying to be efficient wrt to
notifications then it will need to unregister when all netdevices leave
a namespace which it means it has work to do on namespace changes.
next prev parent reply other threads:[~2019-12-20 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 12:35 [patch net-next 0/4] net: allow per-net notifier to follow netdev into namespace Jiri Pirko
2019-12-20 12:35 ` [patch net-next 1/4] net: call call_netdevice_unregister_net_notifiers from unregister Jiri Pirko
2019-12-20 17:59 ` David Ahern
2019-12-20 12:35 ` [patch net-next 2/4] net: push code from net notifier reg/unreg into helpers Jiri Pirko
2019-12-20 18:07 ` David Ahern
2019-12-21 8:07 ` Jiri Pirko
2019-12-20 12:35 ` [patch net-next 3/4] net: introduce dev_net notifier register/unregister variants Jiri Pirko
2019-12-20 19:29 ` Saeed Mahameed
2019-12-21 8:21 ` Jiri Pirko
2019-12-20 12:35 ` [patch net-next 4/4] mlx5: Use dev_net netdevice notifier registrations Jiri Pirko
2019-12-20 18:30 ` David Ahern [this message]
2019-12-21 8:14 ` [patch net-next 0/4] net: allow per-net notifier to follow netdev into namespace Jiri Pirko
2019-12-22 4:57 ` David Ahern
2020-01-06 9:15 ` Jiri Pirko
2020-01-06 16:37 ` David Ahern
2020-01-07 9:11 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72587b16-d459-aa6e-b813-cf14b4118b0c@gmail.com \
--to=dsahern@gmail.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=michaelgur@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=vladbu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).