From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: "Petr Tesařík" <petr@tesarici.cz>, "Eric Dumazet" <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux regressions mailing list <regressions@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>,
stable@kernel.org, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] u64_stats: fix u64_stats_init() for lockdep when used repeatedly in one file
Date: Tue, 2 Apr 2024 15:40:16 +0200 [thread overview]
Message-ID: <72e39571-7122-4f6a-9252-83e663e4b703@leemhuis.info> (raw)
In-Reply-To: <764f2b10-9791-4861-9bef-7160fdb8f3ae@leemhuis.info>
Hi. Top-posting for once, to make this easily accessible to everyone.
Hmmm, looks like Petr's patch for a (minor) 6.8 regression didn't make
any progress in the past two weeks.
Does nobody care? Did nobody merge it because no tree feels really
appropriate? Or am I missing something obvious and making a fool out of
myself by asking these questions? :D
Ciao, Thorsten
#regzbot ignore-activity
On 18.03.24 15:23, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 11.03.24 19:21, Petr Tesařík wrote:
>> On Mon, 11 Mar 2024 18:43:59 +0100
>> Eric Dumazet <edumazet@google.com> wrote:
>>> On Mon, Mar 11, 2024 at 6:25 PM Petr Tesařík <petr@tesarici.cz> wrote:
>>>> On Wed, 6 Mar 2024 12:11:57 +0100
>>>> Petr Tesarik <petr@tesarici.cz> wrote:
>>>>
>>>>> Fix bogus lockdep warnings if multiple u64_stats_sync variables are
>>>>> initialized in the same file.
>>>>>
>>>>> With CONFIG_LOCKDEP, seqcount_init() is a macro which declares:
>>>>>
>>>>> static struct lock_class_key __key;
>>>>>
>>>>> Since u64_stats_init() is a function (albeit an inline one), all calls
>>>>> within the same file end up using the same instance, effectively treating
>>>>> them all as a single lock-class.
>>>> What happens with this fix now?
>>>>
>>>> IIUC it should be reviewed by Eric, but I don't know through which tree
>>>> it should be merged. Any plans yet?
>>>
>>> I thought I gave a reply, but apparently not .
>>>
>>> Reviewed-by: Eric Dumazet <edumazet@google.com>
>>
>> Thank you!
>
> Great. Just wondering, as there afaics was no activity since about one
> week: what is the plan forward here?
>
> Is the "through which tree it should be merged" question still
> unresolved? I quickly looked and it seems two of the last tree changes
> to that file over the past years went through net-next (the other one
> through the tip tree). That's why I CCed the other two net maintainers
> and the net list now.
>
> Or is the plan to merge this after the merge window? Or only merge it
> for 6.10, as it are bogus lockdep warnings that are being fixed?
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> --
> Everything you wanna know about Linux kernel regression tracking:
> https://linux-regtracking.leemhuis.info/about/#tldr
> If I did something stupid, please tell me, as explained on that page.
>
> #regzbot poke
>
>
next prev parent reply other threads:[~2024-04-02 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240306111157.29327-1-petr@tesarici.cz>
[not found] ` <20240311182516.1e2eebd8@meshulam.tesarici.cz>
[not found] ` <CANn89iKQpSaF5KG5=dT_o=WBeZtCiLcN768eUdYvUew-dLbKaA@mail.gmail.com>
[not found] ` <20240311192118.31cfc1fb@meshulam.tesarici.cz>
2024-03-18 14:23 ` [PATCH 1/1] u64_stats: fix u64_stats_init() for lockdep when used repeatedly in one file Linux regression tracking (Thorsten Leemhuis)
2024-04-02 13:40 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2024-04-02 13:42 ` Eric Dumazet
2024-04-02 13:54 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e39571-7122-4f6a-9252-83e663e4b703@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr@tesarici.cz \
--cc=regressions@lists.linux.dev \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).