From: Stefan Wahren <wahrenst@gmx.net>
To: Pkshih <pkshih@realtek.com>, Larry Finger <Larry.Finger@lwfinger.net>
Cc: "colin.king@canonical.com" <colin.king@canonical.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: rtlwifi: Memory leak in rtl92c_set_fw_rsvdpagepkt()
Date: Sat, 2 Nov 2019 01:54:26 +0100 [thread overview]
Message-ID: <72e5ee88-4859-8134-825a-eb103926d2f0@gmx.net> (raw)
In-Reply-To: <5B2DA6FDDF928F4E855344EE0A5C39D1D5C90CAD@RTITMBSVM04.realtek.com.tw>
Am 01.11.19 um 02:18 schrieb Pkshih:
>
>> -----Original Message-----
>> From: Stefan Wahren [mailto:wahrenst@gmx.net]
>> Sent: Thursday, October 31, 2019 9:57 PM
>> To: Pkshih; Larry Finger
>> Cc: colin.king@canonical.com; kvalo@codeaurora.org; linux-wireless@vger.kernel.org;
>> netdev@vger.kernel.org
>> Subject: rtlwifi: Memory leak in rtl92c_set_fw_rsvdpagepkt()
>>
>> Hi,
>>
>> i tested the EDIMAX EW-7612 on Raspberry Pi 3B+ with Linux 5.4-rc5
>> (multi_v7_defconfig + rtlwifi + kmemleak) and noticed a single memory
>> leak during probe:
>>
>> unreferenced object 0xec13ee40 (size 176):
>> comm "kworker/u8:1", pid 36, jiffies 4294939321 (age 5580.790s)
>> hex dump (first 32 bytes):
>> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> backtrace:
>> [<fc1bbb3e>] __netdev_alloc_skb+0x9c/0x164
>> [<863dfa6e>] rtl92c_set_fw_rsvdpagepkt+0x254/0x340 [rtl8192c_common]
>> [<9572be0d>] rtl92cu_set_hw_reg+0xf48/0xfa4 [rtl8192cu]
>> [<116df4d8>] rtl_op_bss_info_changed+0x234/0x96c [rtlwifi]
>> [<8933575f>] ieee80211_bss_info_change_notify+0xb8/0x264 [mac80211]
>> [<d4061e86>] ieee80211_assoc_success+0x934/0x1798 [mac80211]
>> [<e55adb56>] ieee80211_rx_mgmt_assoc_resp+0x174/0x314 [mac80211]
>> [<5974629e>] ieee80211_sta_rx_queued_mgmt+0x3f4/0x7f0 [mac80211]
>> [<d91091c6>] ieee80211_iface_work+0x208/0x318 [mac80211]
>> [<ac5fcae4>] process_one_work+0x22c/0x564
>> [<f5e6d3b6>] worker_thread+0x44/0x5d8
>> [<82c7b073>] kthread+0x150/0x154
>> [<b43e1b7d>] ret_from_fork+0x14/0x2c
>> [<794dff30>] 0x0
>>
>> It looks like the allocated skd is never freed.
>>
>> Would be nice to get this fixed.
>>
> Hi,
>
> This is due to 8192cu doesn't implement usb_cmd_send_packet(). Could you help
> following patch?
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> index 56cc3bc30860..f070f25bb735 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.c
> @@ -1540,6 +1540,8 @@ static bool usb_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb)
> * This is maybe necessary:
> * rtlpriv->cfg->ops->fill_tx_cmddesc(hw, buffer, 1, 1, skb);
> */
> + dev_kfree_skb(skb);
> +
> return true;
> }
>
> This patch just frees the skb to resolve memleak problem. Since 8192cu doesn't
> turn on fwctrl_lps that needs to download command packet to firmware, apply
> this patch isn't worse than before.
Yes, the patch fixes the memleak.
Thanks
Stefan
>
> ---
> PK
>
prev parent reply other threads:[~2019-11-02 0:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 13:56 rtlwifi: Memory leak in rtl92c_set_fw_rsvdpagepkt() Stefan Wahren
2019-11-01 1:18 ` Pkshih
2019-11-02 0:54 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72e5ee88-4859-8134-825a-eb103926d2f0@gmx.net \
--to=wahrenst@gmx.net \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).