netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>,
	"jsorensen@fb.com" <jsorensen@fb.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/1] Fix broken build of mlx5
Date: Tue, 25 Jun 2019 14:01:56 -0400	[thread overview]
Message-ID: <74cb713f-ad8c-7f86-c611-9dd4265f1c9b@gmail.com> (raw)
In-Reply-To: <134e3a684c27fddeeeac111e5b4fac4093473731.camel@mellanox.com>

On 6/25/19 1:54 PM, Saeed Mahameed wrote:
> On Tue, 2019-06-25 at 11:27 -0400, Jes Sorensen wrote:
>> From: Jes Sorensen <jsorensen@fb.com>
>>
>> This fixes an obvious build error that could have been caught by
>> simply building the code before pushing out the patch.
>>
> 
> Hi Jes,
> 
> Just tested again, as I have tested before submitting the blamed patch,
> and as we test on every single new patch in our build automation.
> 
> both combinations CONFIG_MLX5_EN_RXNFC=y/n work on latest net-next,
> what am i missing ?

Linus' tree:

[jes@xpeas linux.git]$ grep mlx5e_get_rxnfc
drivers/net/ethernet/mellanox/mlx5/core/*.c
drivers/net/ethernet/mellanox/mlx5/core/en/*.h
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:static int
mlx5e_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *info, u32
*rule_locs)
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c:	.get_rxnfc
= mlx5e_get_rxnfc,
drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c:int
mlx5e_get_rxnfc(struct net_device *dev,
drivers/net/ethernet/mellanox/mlx5/core/en/fs.h:int
mlx5e_get_rxnfc(struct net_device *dev,

static vs non static functions, with a prototype that is non static.

Jes

  reply	other threads:[~2019-06-25 18:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 15:27 [PATCH 0/1] Fix broken build of mlx5 Jes Sorensen
2019-06-25 15:27 ` [PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled Jes Sorensen
2019-06-25 18:00   ` Saeed Mahameed
2019-07-02 15:00     ` Jes Sorensen
2019-06-25 20:34   ` David Miller
2019-06-25 21:01     ` Saeed Mahameed
2019-06-25 21:08       ` David Miller
2019-06-26 19:08         ` Saeed Mahameed
2019-06-25 17:54 ` [PATCH 0/1] Fix broken build of mlx5 Saeed Mahameed
2019-06-25 18:01   ` Jes Sorensen [this message]
2019-06-25 21:11     ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74cb713f-ad8c-7f86-c611-9dd4265f1c9b@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=jsorensen@fb.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).