From: Logan Gunthorpe <logang@deltatee.com>
To: Dongdong Liu <liudongdong3@huawei.com>,
helgaas@kernel.org, hch@infradead.org, kw@linux.com,
leon@kernel.org, linux-pci@vger.kernel.org, rajur@chelsio.com,
hverkuil-cisco@xs4all.nl
Cc: linux-media@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH V7 7/9] PCI/sysfs: Add a 10-Bit Tag sysfs file
Date: Wed, 4 Aug 2021 09:51:29 -0600 [thread overview]
Message-ID: <75243571-3213-6ae2-040f-ae1b1f799e42@deltatee.com> (raw)
In-Reply-To: <1628084828-119542-8-git-send-email-liudongdong3@huawei.com>
On 2021-08-04 7:47 a.m., Dongdong Liu wrote:
> PCIe spec 5.0 r1.0 section 2.2.6.2 says that if an Endpoint supports
> sending Requests to other Endpoints (as opposed to host memory), the
> Endpoint must not send 10-Bit Tag Requests to another given Endpoint
> unless an implementation-specific mechanism determines that the Endpoint
> supports 10-Bit Tag Completer capability. Add a 10bit_tag sysfs file,
> write 0 to disable 10-Bit Tag Requester when the driver does not bind
> the device if the peer device does not support the 10-Bit Tag Completer.
> This will make P2P traffic safe. the 10bit_tag file content indicate
> current 10-Bit Tag Requester Enable status.
Can we not have both the sysfs file and the command line parameter? If
the user wants to disable it always for a specific device this sysfs
parameter is fairly awkward. A script at boot to unbind the driver, set
the sysfs file and rebind the driver is not trivial and the command line
parameter offers additional options for users.
Logan
next prev parent reply other threads:[~2021-08-04 15:51 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 13:46 [PATCH V7 0/9] PCI: Enable 10-Bit tag support for PCIe devices Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 1/9] PCI: Use cached Device Capabilities Register Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 2/9] PCI: Use cached Device Capabilities 2 Register Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 3/9] PCI: Add 10-Bit Tag register definitions Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 4/9] PCI: Enable 10-Bit Tag support for PCIe Endpoint devices Dongdong Liu
2021-08-04 23:17 ` Bjorn Helgaas
2021-08-05 7:47 ` Dongdong Liu
2021-08-05 19:54 ` Bjorn Helgaas
2021-08-07 6:19 ` Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 5/9] PCI/IOV: Enable 10-Bit tag support for PCIe VF devices Dongdong Liu
2021-08-04 23:29 ` Bjorn Helgaas
2021-08-05 8:03 ` Dongdong Liu
2021-08-06 22:59 ` Bjorn Helgaas
2021-08-07 7:46 ` Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 6/9] PCI: Enable 10-Bit Tag support for PCIe RP devices Dongdong Liu
2021-08-04 23:38 ` Bjorn Helgaas
2021-08-05 8:25 ` Dongdong Liu
2021-08-09 17:26 ` Bjorn Helgaas
2021-08-10 11:59 ` Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 7/9] PCI/sysfs: Add a 10-Bit Tag sysfs file Dongdong Liu
2021-08-04 15:51 ` Logan Gunthorpe [this message]
2021-08-05 13:14 ` Dongdong Liu
2021-08-05 13:53 ` Leon Romanovsky
2021-08-05 15:36 ` Logan Gunthorpe
2021-08-04 23:49 ` Bjorn Helgaas
2021-08-05 8:37 ` Dongdong Liu
2021-08-05 15:31 ` Bjorn Helgaas
2021-08-07 7:01 ` Dongdong Liu
2021-08-09 17:37 ` Bjorn Helgaas
2021-08-10 12:16 ` Dongdong Liu
2021-08-04 23:52 ` Bjorn Helgaas
2021-08-05 8:38 ` Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 8/9] PCI/IOV: Add 10-Bit Tag sysfs files for VF devices Dongdong Liu
2021-08-05 0:05 ` Bjorn Helgaas
2021-08-05 8:47 ` Dongdong Liu
2021-08-05 9:39 ` Dongdong Liu
2021-08-04 13:47 ` [PATCH V7 9/9] PCI/P2PDMA: Add a 10-Bit Tag check in P2PDMA Dongdong Liu
2021-08-04 15:56 ` Logan Gunthorpe
2021-08-05 8:49 ` Dongdong Liu
2021-08-05 18:12 ` Bjorn Helgaas
2021-08-07 7:11 ` Dongdong Liu
2021-08-09 17:31 ` Bjorn Helgaas
2021-08-10 12:31 ` Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75243571-3213-6ae2-040f-ae1b1f799e42@deltatee.com \
--to=logang@deltatee.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kw@linux.com \
--cc=leon@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=rajur@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).