netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eyal Birger <eyal.birger@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: Rename sock_recv_ts_and_drops() to sock_cmsg_recv()
Date: Tue, 10 Feb 2015 14:57:11 +0200	[thread overview]
Message-ID: <75B13C03-8E9F-4E70-9DAD-FFE187A3DF15@gmail.com> (raw)
In-Reply-To: <20150209.185535.1300672977479433508.davem@davemloft.net>

Hi,

> On Feb 10, 2015, at 4:55 AM, David Miller <davem@davemloft.net> wrote:
> 
> From: Eyal Birger <eyal.birger@gmail.com>
> Date: Mon,  9 Feb 2015 20:15:21 +0200
> 
>> -void __sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk,
>> +void __sock_cmsg_recv(struct msghdr *msg, struct sock *sk,
>> 			      struct sk_buff *skb);
> 
> If you change the column where the openning parenthesis of a function
> declaration appears, you have to reindent the subsequent lines,
> if any, so that the arguments still begin at the first column after
> that openning parenthesis.

Sorry about that, thanks! Will fix.

> Also, this new feature is too late for this merge window, so there is
> no rush for resubmitting this.

Thanks. Should I wait for the next merge window or may I resubmit at this point?

Regards,
Eyal.

  reply	other threads:[~2015-02-10 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 18:15 [PATCH net-next 0/3] net: Introducing socket mark receive socket option Eyal Birger
2015-02-09 18:15 ` [PATCH net-next 1/3] net: Rename sock_recv_ts_and_drops() to sock_cmsg_recv() Eyal Birger
2015-02-10  2:55   ` David Miller
2015-02-10 12:57     ` Eyal Birger [this message]
2015-02-09 18:15 ` [PATCH net-next 2/3] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark Eyal Birger
2015-02-09 18:15 ` [PATCH net-next 3/3] net: Introducing socket mark receive socket option Eyal Birger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75B13C03-8E9F-4E70-9DAD-FFE187A3DF15@gmail.com \
    --to=eyal.birger@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).