From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BFFC43381 for ; Fri, 22 Feb 2019 22:37:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C028D206C0 for ; Fri, 22 Feb 2019 22:37:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tu2bOY1t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726471AbfBVWhp (ORCPT ); Fri, 22 Feb 2019 17:37:45 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34849 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfBVWho (ORCPT ); Fri, 22 Feb 2019 17:37:44 -0500 Received: by mail-pg1-f195.google.com with SMTP id s198so1752989pgs.2; Fri, 22 Feb 2019 14:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jcZRjyScsTwxF+sgWz2MhUspojUcV8VLY4BSLKOIBLY=; b=Tu2bOY1toXWZqWH3Nmt6nX5HscEeriIVmGgpUsfzByBoxYjRq6CSdiy/JBiwIeZQqg nMYOYdrsGmBuZZldNP217anjaPRz/Dd9KezZWrqZI3p5Me7mGXtyhzi2++cYNDN/xlcV yp09R/3XvxUL7nh9sUceJ+StDDbZ9Q3TBB5Mh6iBPIIaM3Mgx5SgXkjkfOc98VOLFs5b vi2d9o1xgQvag3kdfAi26VGTuJu4zRGPnBMUgDTCqQ1V5n1Wd4gG0SfwFEpLWbjtlHKA FfpPPVyacW4gdwZ9r8NLOJy5rDdf2KZ/8FiDqobC6cG4zhKg4MNfow25t+tHSdenM80X tBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jcZRjyScsTwxF+sgWz2MhUspojUcV8VLY4BSLKOIBLY=; b=MYMjk0S2+1Rr80nHuj5N4dCHUNwzgf5EBe1LfKVD4nQtF/C1vwKudIYk8btIWmchEe 4OuMN/b+ePIIADlbOjbjnqaR8EjEIuy5SfYdC07PaxKcu3YBprb0PmNVu8oF52zrXntA qoyQgnljAuZiFTQYyinHBmYMYGRZYsgi73aiA6fXK7gCSk/Sp4wWFFJOk4rLuqsCYLfg P3qaw5X5Zq4Hgl62Xv6h0HQhnc+H+zrq0B2nBOXNfdO1t6zZ1NCDWaCdtsfTlkQeWqVO rRq2UPxIpaMtkiJsKzQ526MM2IyJb71ZVsXKxllao/ZirnmX3wKU7qd9uL58HCMvinyV 18Tw== X-Gm-Message-State: AHQUAuaW9H6KLr+2lwAHXvmpuaq5OlaYlZ3e4d4uqTcfPgTsWbGfrY4P dM2UpEwKnLdKUluaA79XDAU= X-Google-Smtp-Source: AHgI3Ia9E/f4FmGxRND07H2PhWbyvtZSrf/JgC+Vvzojxknp4a9oH+qZxhQEM9XA6+jtlPU10qMsYA== X-Received: by 2002:a63:61c9:: with SMTP id v192mr6290220pgb.120.1550875064324; Fri, 22 Feb 2019 14:37:44 -0800 (PST) Received: from [172.27.227.214] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id e63sm6505005pfc.47.2019.02.22.14.37.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Feb 2019 14:37:43 -0800 (PST) Subject: Re: [PATCH] selftests: fib_tests: sleep after changing carrier. again. To: Thadeu Lima de Souza Cascardo , netdev@vger.kernel.org Cc: linux-kselftest@vger.kernel.org, David Ahern References: <20190222102741.31173-1-cascardo@canonical.com> From: David Ahern Message-ID: <767c0a6e-41a4-e1cd-00a4-197cbcb41af5@gmail.com> Date: Fri, 22 Feb 2019 17:37:41 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190222102741.31173-1-cascardo@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/22/19 5:27 AM, Thadeu Lima de Souza Cascardo wrote: > Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after > changing carrier"), wait one second to allow linkwatch to propagate the > carrier change to the stack. > > There are two sets of carrier tests. The first slept after the carrier > was set to off, and when the second set ran, it was likely that the > linkwatch would be able to run again without much delay, reducing the > likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a > loop, you will quickly notice the failures. > > Sleeping on the second set of tests make the failures go away. > > Cc: David Ahern > Signed-off-by: Thadeu Lima de Souza Cascardo > --- > tools/testing/selftests/net/fib_tests.sh | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: David Ahern