From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA9DC43381 for ; Sat, 16 Feb 2019 00:37:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3F7F222A1 for ; Sat, 16 Feb 2019 00:37:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o7TtJzAo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394356AbfBPAhm (ORCPT ); Fri, 15 Feb 2019 19:37:42 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:40987 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728838AbfBPAhm (ORCPT ); Fri, 15 Feb 2019 19:37:42 -0500 Received: by mail-yb1-f196.google.com with SMTP id 18so2886496ybf.8; Fri, 15 Feb 2019 16:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bwa73KKS0GHzhM/Hzm2y4AjhgGLRJoVnB/9q7JdY9I0=; b=o7TtJzAovHV0e9HulFcY9NIxhSljIAHEhWWHgYoiqbaxed4QjBlsvgpYv/2J7Bs1OR PkdHPub3WNOgbwI9SNj2Ctsi/cO0Qt/McHiB6/wXWvxasbdCt4D7GzE8fuDQE11rP9k4 UEQISInf0kRzyBQ2u6NmrCJc+lIEHeEnYaI18a8ZD+mAnWzGnyL/NaMDp9ENpqYgXnDg KHVd1mynMujvBjFUF9CME2c2LCK+u2zL1XbfFzm27E4HKOY8eg5qcqMM6d5E7SJpXaFx A+BlMS/FjIjzOiUtfpfLw25T5FLWri/ptmQtvMe5pUrumXDOXtDNJxTNoxDgaQWYub9r xXcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bwa73KKS0GHzhM/Hzm2y4AjhgGLRJoVnB/9q7JdY9I0=; b=SdCSvoLu/IqeA2LzHtGSwiFTv6ftK02t6R2n8g+7tvLpagfnr7GXFez7bGO+eydjfE SWEuMxW3nSv5Pgv3a5o+nB+V0MZSRp8xQgVOVVSnususb3LBbJA/zYzeyZvKEd/Fb7HB G1GRJctqFCagyfIyLHjFRSqe8aww+sg9p/9eqYEcIi+k5Xg88nZ0DnSDi8a07ZCAIok5 Nj1uo1m03UhhKmSgfiG9EXCzLQtIjFCUyw/nsqjt2gYGzWVK6mj0oWe0GjHdiqQ8jocb utlUirIalotHr7m3js8sF7vEHU82ON2+w/gGS7hlBXgYxWlvk0NjD1HvqgelEvCuSx/6 SWyA== X-Gm-Message-State: AHQUAuZCeUwIw/Oqz4sU9nvptYTRMFn+hsuJwYn9/o1B5498VgLxn/Ha /SO11nmPT+8Yymbp7gEUFmM= X-Google-Smtp-Source: AHgI3IYLkYXA1BJuaOZBZ3iqaWo9pLxEtJB8IdTXw/s1S7kKF9B5nMwboVQx7ewnidq7FphwroNf0w== X-Received: by 2002:a25:8b09:: with SMTP id i9mr10097808ybl.153.1550277460671; Fri, 15 Feb 2019 16:37:40 -0800 (PST) Received: from [10.67.48.220] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id j82sm2050270ywj.91.2019.02.15.16.37.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 16:37:39 -0800 (PST) Subject: Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get() To: netdev@vger.kernel.org, "David S. Miller" Cc: Ido Schimmel , open list , "open list:STAGING SUBSYSTEM" , "moderated list:ETHERNET BRIDGE" , jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com References: <20190215225313.32303-1-f.fainelli@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <77c28e2d-cd29-4932-5cfe-64799c730ede@gmail.com> Date: Fri, 15 Feb 2019 16:37:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190215225313.32303-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/15/19 2:53 PM, Florian Fainelli wrote: > Hi all, > > This patch series splits the removal of the switchdev_ops that was > proposed a few times before and first tackles the easy part which is the > removal of the single call to switchdev_port_attr_get() within the > bridge code. > > As suggestd by Ido, this patch series adds a > SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS which is used in the same > context as the caller of switchdev_port_attr_set(), so not deferred, and > then the operation is carried out in deferred context with setting a > support bridge port flag. > > Follow-up patches will do the switchdev_ops removal after introducing > the proper helpers for the switchdev blocking notifier to work across > stacked devices (unlike the previous submissions). David, please ignore this version, I will repost one that actually builds, need to keep mangling with my kernel configuration and keep those drivers enabled... > > Changes in v2: > > - differentiate callers not supporting switchdev_port_attr_set() from > the driver not being able to support specific bridge flags > > - pass "mask" instead of "flags" for the PRE_BRIDGE_FLAGS check > > - skip prepare phase for PRE_BRIDGE_FLAGS > > - corrected documentation a bit more > > - tested bridge_vlan_aware.sh with veth/VRF > > Florian Fainelli (9): > Documentation: networking: switchdev: Update port parent ID section > net: switchdev: Add PORT_PRE_BRIDGE_FLAGS > mlxsw: spectrum: Handle PORT_PRE_BRIDGE_FLAGS > staging: fsl-dpaa2: ethsw: Handle PORT_PRE_BRIDGE_FLAGS > net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS > rocker: Check Handle PORT_PRE_BRIDGE_FLAGS > net: bridge: Stop calling switchdev_port_attr_get() > net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT > net: Get rid of switchdev_port_attr_get() > > Documentation/networking/switchdev.txt | 16 ++-- > .../mellanox/mlxsw/spectrum_switchdev.c | 38 +++++----- > drivers/net/ethernet/rocker/rocker_main.c | 75 +++++++++++-------- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 32 ++++---- > include/net/switchdev.h | 13 +--- > net/bridge/br_switchdev.c | 11 ++- > net/dsa/dsa_priv.h | 6 ++ > net/dsa/port.c | 17 +++++ > net/dsa/slave.c | 24 +++--- > 9 files changed, 128 insertions(+), 104 deletions(-) > -- Florian