From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Pankaj Sharma <pankj.sharma@samsung.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: wg@grandegger.com, davem@davemloft.net,
eugen.hristev@microchip.com, ludovic.desroches@microchip.com,
pankaj.dubey@samsung.com, rcsekar@samsung.com,
Sriram Dash <sriram.dash@samsung.com>
Subject: Re: [PATCH] can: m_can: add support for one shot mode
Date: Fri, 4 Oct 2019 22:41:57 +0200 [thread overview]
Message-ID: <79c10dd5-0c44-ce70-9cb9-bb61e12362d4@pengutronix.de> (raw)
In-Reply-To: <1569411904-6319-1-git-send-email-pankj.sharma@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]
On 9/25/19 1:45 PM, Pankaj Sharma wrote:
> According to the CAN Specification (see ISO 11898-1:2015, 8.3.4
> Recovery Management), the M_CAN provides means for automatic
> retransmission of frames that have lost arbitration or that
> have been disturbed by errors during transmission. By default
> automatic retransmission is enabled.
>
> The Bosch MCAN controller has support for disabling automatic
> retransmission.
>
> To support time-triggered communication as described in ISO
> 11898-1:2015, chapter 9.2, the automatic retransmission may be
> disabled via CCCR.DAR.
>
> CAN_CTRLMODE_ONE_SHOT is used for disabling automatic retransmission.
>
> Signed-off-by: Pankaj Sharma <pankj.sharma@samsung.com>
> Signed-off-by: Sriram Dash <sriram.dash@samsung.com>
The patch does not apply to net-next/master. Please use net-next/master
as a base for patches introducing new features.
I've ported the patch and applied it.
tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-04 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190925114609epcas5p305e259619c7fe8cdc75d9fd27f34e758@epcas5p3.samsung.com>
2019-09-25 11:45 ` [PATCH] can: m_can: add support for one shot mode Pankaj Sharma
2019-10-03 3:47 ` pankj.sharma
2019-10-04 20:41 ` Marc Kleine-Budde [this message]
2019-10-14 11:30 ` pankj.sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c10dd5-0c44-ce70-9cb9-bb61e12362d4@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=eugen.hristev@microchip.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=pankj.sharma@samsung.com \
--cc=rcsekar@samsung.com \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).