From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9E4C4727E for ; Wed, 23 Sep 2020 15:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B153F2223E for ; Wed, 23 Sep 2020 15:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbgIWPCW (ORCPT ); Wed, 23 Sep 2020 11:02:22 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:58671 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726130AbgIWPCW (ORCPT ); Wed, 23 Sep 2020 11:02:22 -0400 Received: from [141.14.220.45] (g45.guest.molgen.mpg.de [141.14.220.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 5DB2320646201; Wed, 23 Sep 2020 17:02:20 +0200 (CEST) Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Power cycle phy on PM resume To: Kai-Heng Feng Cc: Jeff Kirsher , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , "David S. Miller" References: <20200923074751.10527-1-kai.heng.feng@canonical.com> <17092088-86ff-2d31-b3de-2469419136a3@molgen.mpg.de> From: Paul Menzel Message-ID: <79f01082-c9b1-f80a-7af4-b61bdbf40c90@molgen.mpg.de> Date: Wed, 23 Sep 2020 17:02:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Kai-Heng, Am 23.09.20 um 16:46 schrieb Kai-Heng Feng: >> On Sep 23, 2020, at 21:28, Paul Menzel wrote: >> Am 23.09.20 um 09:47 schrieb Kai-Heng Feng: >>> We are seeing the following error after S3 resume: >>> [ 704.746874] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >>> [ 704.844232] e1000e 0000:00:1f.6 eno1: MDI Write did not complete >>> [ 704.902817] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >>> [ 704.903075] e1000e 0000:00:1f.6 eno1: reading PHY page 769 (or 0x6020 shifted) reg 0x17 >>> [ 704.903281] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 >>> [ 704.903486] e1000e 0000:00:1f.6 eno1: writing PHY page 769 (or 0x6020 shifted) reg 0x17 >>> [ 704.943155] e1000e 0000:00:1f.6 eno1: MDI Error >>> ... >>> [ 705.108161] e1000e 0000:00:1f.6 eno1: Hardware Error >>> Since we don't know what platform firmware may do to the phy, so let's >>> power cycle the phy upon system resume to resolve the issue. >> >> Is there a bug report or list thread for this issue? > > No. That's why I sent a patch to start discussion :) Then please add on what systems that is. >>> Signed-off-by: Kai-Heng Feng >>> --- >>> drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c >>> index 664e8ccc88d2..c2a87a408102 100644 >>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c >>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c >>> @@ -6968,6 +6968,8 @@ static __maybe_unused int e1000e_pm_resume(struct device *dev) >>> !e1000e_check_me(hw->adapter->pdev->device)) >>> e1000e_s0ix_exit_flow(adapter); >>> + e1000_power_down_phy(adapter); >>> + >>> rc = __e1000_resume(pdev); >>> if (rc) >>> return rc; >> >> How much does this increase the resume time? > > I didn't measure it. Because for me it's more important to have a working device. > > Does it have a noticeable impact on your system's resume time? I am not able to test the patch right now. But resume time is important to me. As I do not have the problem, nothing should be changed for my system (Dell Latitude E7250). 00:19.0 Ethernet controller [0200]: Intel Corporation Ethernet Connection (3) I218-LM [8086:15a2] (rev 03) Kind regards, Paul