From: "Cloutier, Joseph (Joseph)" <joseph.cloutier@alcatel-lucent.com>
To: "'YOSHIFUJI Hideaki'" <yoshfuji@linux-ipv6.org>
Cc: "'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
"'Linus Torvalds'" <torvalds@linux-foundation.org>
Subject: RE: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping
Date: Mon, 6 Feb 2012 14:54:57 -0600 [thread overview]
Message-ID: <7D3B6706FA74174B8C1AC24710890745136F61C577@USNAVSXCHMBSA1.ndc.alcatel-lucent.com> (raw)
In-Reply-To: <7D3B6706FA74174B8C1AC24710890745136F1A0C15@USNAVSXCHMBSA1.ndc.alcatel-lucent.com>
Hideaki, can you give me any status on this request? Was it rejected, is it pending? Thanks, Joe Cloutier
-----Original Message-----
From: Cloutier, Joseph (Joseph)
Sent: Tuesday, January 10, 2012 1:01 PM
To: 'YOSHIFUJI Hideaki'
Cc: 'netdev@vger.kernel.org'; 'Linus Torvalds'
Subject: [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after
"-c" xmitted, and "-c" was exceeded for flood ping
From: Joseph Cloutier <jcloutier@alcatel-lucent.com>
2 changes to ping & ping6. Only ping_common.c affected.
1- changed "-w deadline" to start deadline after "-c" pings have been transmitted, instead of from start of run.
2- fixed bug where > "-c" pings are sent in flood ping mode when "-w deadline" option is also used.
Reason:
Linux flood ping is an invaluable tool to finding duplex bugs, fiber problems, NE config problems- especially
when used to trouble shoot wireless system backhaul problems. ANY dropped pings are red flag indicators.
Current ping problem is that it terminates sometimes when outstanding pings are in transit, giving FALSE red
flags. Change "-w deadline" to start after last "-c" transmitted ping allows cleanup of stragglers. Second fix is
when "-f" option is running, "-c" is not rigorously checked when generating pings A more rigorous check was
added.
Signed-off-by: Joseph Cloutier <jcloutier@alcatel-lucent.com>
---
--- iputils-s20101006/ping_common.c.orig 2012-01-10 10:37:40.399719858 -0500
+++ iputils-s20101006/ping_common.c 2012-01-10 11:33:37.084662882 -0500
@@ -523,16 +523,6 @@ void setup(int icmp_sock)
gettimeofday(&start_time, NULL);
- if (deadline) {
- struct itimerval it;
-
- it.it_interval.tv_sec = 0;
- it.it_interval.tv_usec = 0;
- it.it_value.tv_sec = deadline;
- it.it_value.tv_usec = 0;
- setitimer(ITIMER_REAL, &it, NULL);
- }
-
if (isatty(STDOUT_FILENO)) {
struct winsize w;
@@ -553,6 +543,7 @@ void main_loop(int icmp_sock, __u8 *pack
int cc;
int next;
int polling;
+ int sig_deadline = 0;
iov.iov_base = (char *)packet;
@@ -567,9 +558,22 @@ void main_loop(int icmp_sock, __u8 *pack
/* Check for and do special actions. */
if (status_snapshot)
status();
+ if((npackets == ntransmitted) && deadline &&
+ (sig_deadline == 0)){
+ sig_deadline++;
+ struct itimerval it;
+
+ it.it_interval.tv_sec = 0;
+ it.it_interval.tv_usec = 0;
+ it.it_value.tv_sec = deadline;
+ it.it_value.tv_usec = 0;
+ setitimer(ITIMER_REAL, &it, NULL);
+ }
/* Send probes scheduled to this time. */
do {
+ if(npackets == ntransmitted)
+ break;
next = pinger();
next = schedule_exit(next);
} while (next <= 0);
next prev parent reply other threads:[~2012-02-06 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7D3B6706FA74174B8C1AC24710890745136F1A0C15@USNAVSXCHMBSA1.ndc.alcatel-lucent.com>
2012-02-02 17:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
2012-02-06 20:54 ` Cloutier, Joseph (Joseph) [this message]
2012-02-21 12:21 ` YOSHIFUJI Hideaki
2012-02-21 14:08 ` Cloutier, Joseph (Joseph)
2012-01-10 3:54 "-w deadline" bug in ping/iputils- i will provide fix if you can tell me where owner of iputils is. Thanks YOSHIFUJI Hideaki
2012-01-10 18:00 ` [PATCH] iputils-s20101006.tar.bz2: "-w deadline" starts after "-c" xmitted, and "-c" was exceeded for flood ping Cloutier, Joseph (Joseph)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7D3B6706FA74174B8C1AC24710890745136F61C577@USNAVSXCHMBSA1.ndc.alcatel-lucent.com \
--to=joseph.cloutier@alcatel-lucent.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).