From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Shimamoto Subject: Re: [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode Date: Thu, 5 Feb 2015 06:10:34 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E21852@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05E1908D@BPXM14GP.gisp.nec.co.jp> <1423054641.2589.59.camel@jtkirshe-mobl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "e1000-devel@lists.sourceforge.net" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , "netdev@vger.kernel.org" , =?utf-8?B?QmrDuHJuIE1vcms=?= To: Jeff Kirsher Return-path: In-Reply-To: <1423054641.2589.59.camel@jtkirshe-mobl> Content-Language: ja-JP List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org > Subject: Re: [E1000-devel] [PATCH 1/3] ixgbe, ixgbevf: Add new mbox API to enable MC promiscuous mode > > On Fri, 2015-01-30 at 11:37 +0000, Hiroshi Shimamoto wrote: > > From: Hiroshi Shimamoto > > > > The limitation of the number of multicast address for VF is not enough > > for the large scale server with SR-IOV feature. > > IPv6 requires the multicast MAC address for each IP address to handle > > the Neighbor Solicitation message. > > We couldn't assign over 30 IPv6 addresses to a single VF interface. > > > > The easy way to solve this is enabling multicast promiscuous mode. > > It is good to have a functionality to enable multicast promiscuous > > mode > > for each VF from VF driver. > > > > This patch introduces the new mbox API, IXGBE_VF_SET_MC_PROMISC, to > > enable/disable multicast promiscuous mode in VF. If multicast > > promiscuous > > mode is enabled the VF can receive all multicast packets. > > > > With this patch, the ixgbevf driver automatically enable multicast > > promiscuous mode when the number of multicast addresses is over than > > 30 > > if possible. > > > > This also bump the API version up to 1.2 to check whether the API, > > IXGBE_VF_SET_MC_PROMISC is available. > > > > Signed-off-by: Hiroshi Shimamoto > > Reviewed-by: Hayato Momma > > CC: Choi, Sy Jong > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 89 > > ++++++++++++++++++++++- > > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 13 +++- > > drivers/net/ethernet/intel/ixgbevf/mbx.h | 4 + > > drivers/net/ethernet/intel/ixgbevf/vf.c | 29 +++++++- > > drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + > > 7 files changed, 137 insertions(+), 4 deletions(-) > > Hiroshi, I tried to apply your patches to my queue but they do not apply > cleanly and they are in a DOS file format, not UNIX. I also noted > several checkpatch.pl issues with your patches, so please fix those up > as well. I'm sorry to bother you. Will fix. > > Can you please fix up your patches based on my tree: > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/queue.git Yes. I haven't noticed your tree. Will resend patches against it. thanks, Hiroshi > > This my queue of all community patches against the Intel LAN drivers and > will be where I queue up your patches while they are under review and > testing. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired