From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A28C433DB for ; Tue, 29 Dec 2020 08:18:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2481721D1B for ; Tue, 29 Dec 2020 08:18:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgL2IRw (ORCPT ); Tue, 29 Dec 2020 03:17:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgL2IRv (ORCPT ); Tue, 29 Dec 2020 03:17:51 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49A0AC0613D6; Tue, 29 Dec 2020 00:17:11 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id 23so29087878lfg.10; Tue, 29 Dec 2020 00:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8yoRVgdzslZ2s5VNKQ7c0EICKigH3eQ9ghrStUXwk4g=; b=NAXzB5SEXKT2bdZhaJkeCOkkfpKiPGJBBASxeYQOSpuat0xf42fmQCDnSwxSBPCWrh 2jFqaAMVDjwhpqvLkqvaAHUjh1AKm0Y6j3+PWZMuoVRtshT8nnuNM3EVkQCFTdQbo5/k k2TkqTCZfQfb0nVfkP+r0Tbq2K9Wzc0l+NdO9x1GS+HfUFW/WCJzSSG/5cm51cubJrak jwLpgut8CURr+wpKmoAOwYaNa1KDQ7fMv4GFHmkkW3d5tgRL0jER429lsliDYUG7B9Fh A3lTxYrbbrA8C7qGq4PAZ3U3PrvXW4K4dIdS6wCCXu1Tndl3KPSpMIjumF+l6pGv3Ahc hYzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8yoRVgdzslZ2s5VNKQ7c0EICKigH3eQ9ghrStUXwk4g=; b=a4x0iYhvLQWm1PU2aF69o4K94pxIEP8xueIeUQ94i4F1HJO1ZTFDklUfYc1GGDaR9a z5vQmCWgSZ4EgqmkwTx3+JGStLYshKQKYkMY6heAScwXR5v2mC1lM7myPZ91SJLF2EVu KAEFtiKAiMrYmZXVgvGVz1CGyZ8ppi+MPbcPMvok6ZTs3A/dhjLQ1UUoyK0496RiMmiL nq32WXaP3bjIMiPTQfmwLN1nd3MMPUQFgD6k05DNrurzS7fEQq6VImmOaGhFvgrgdnGM 65rrXY8fPlLtelwg8DwHdvFpMT7cEw3sl5AP2tjcY3ti7QZl6ubMT+EPaiu0mimOyZ7G Fbkw== X-Gm-Message-State: AOAM53272ZsMdStBke1kNsJ/FN0oRYdPKD7heOpyPWIS6doni/GLszF/ 60reyDokhxp1NTCZjF3pVedE4ujv+I4= X-Google-Smtp-Source: ABdhPJwI4Qk5tmYMi5kKb5Z0GK99s9dL1UCkByjF5rAXM5cHmVOfPpXmRZYHrusB374Mi/s3hM8iwQ== X-Received: by 2002:a19:9d8:: with SMTP id 207mr20532632lfj.581.1609229829361; Tue, 29 Dec 2020 00:17:09 -0800 (PST) Received: from [192.168.1.100] ([178.176.78.246]) by smtp.gmail.com with ESMTPSA id u14sm6875979ljo.72.2020.12.29.00.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Dec 2020 00:17:08 -0800 (PST) Subject: Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks To: Adam Ford , linux-renesas-soc@vger.kernel.org Cc: aford@beaconembedded.com, "David S. Miller" , Jakub Kicinski , Rob Herring , Geert Uytterhoeven , Magnus Damm , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201228213121.2331449-1-aford173@gmail.com> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: <7b271d36-3178-0338-7bfb-558115cb2516@gmail.com> Date: Tue, 29 Dec 2020 11:17:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201228213121.2331449-1-aford173@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 29.12.2020 0:31, Adam Ford wrote: > The AVB driver assumes there is an external clock, but it could > be driven by an external clock. Driver can be driven by external clock? :-) > In order to enable a programmable > clock, it needs to be added to the clocks list and enabled in the > driver. Since there currently only one clock, there is no ^ is > clock-names list either. > > Update bindings to add the additional optional clock, and explicitly > name both of them. > > Signed-off-by: Adam Ford [...] MBR, Sergei