From: Doug Berger <opendmb@gmail.com>
To: Zhang Changzhong <zhangchangzhong@huawei.com>,
f.fainelli@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: add missed clk_disable_unprepare in bcmgenet_probe
Date: Mon, 20 Jul 2020 09:02:22 -0700 [thread overview]
Message-ID: <7b499451-623c-cabf-2c95-fc7019895b3d@gmail.com> (raw)
In-Reply-To: <1595237794-11530-1-git-send-email-zhangchangzhong@huawei.com>
On 7/20/2020 2:36 AM, Zhang Changzhong wrote:
> The driver forgets to call clk_disable_unprepare() in error path after
> a success calling for clk_prepare_enable().
>
> Fix to goto err_clk_disable if clk_prepare_enable() is successful.
>
> Fixes: c80d36ff63a5 ("net: bcmgenet: Use devm_clk_get_optional() to get the clocks")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 368e05b..79d27be 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -4000,14 +4000,14 @@ static int bcmgenet_probe(struct platform_device *pdev)
> if (IS_ERR(priv->clk_wol)) {
> dev_dbg(&priv->pdev->dev, "failed to get enet-wol clock\n");
> err = PTR_ERR(priv->clk_wol);
> - goto err;
> + goto err_clk_disable;
> }
>
> priv->clk_eee = devm_clk_get_optional(&priv->pdev->dev, "enet-eee");
> if (IS_ERR(priv->clk_eee)) {
> dev_dbg(&priv->pdev->dev, "failed to get enet-eee clock\n");
> err = PTR_ERR(priv->clk_eee);
> - goto err;
> + goto err_clk_disable;
> }
>
> /* If this is an internal GPHY, power it on now, before UniMAC is
>
Acked-by: Doug Berger <opendmb@gmail.com>
Thanks!
next prev parent reply other threads:[~2020-07-20 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:36 [PATCH net] net: bcmgenet: add missed clk_disable_unprepare in bcmgenet_probe Zhang Changzhong
2020-07-20 16:02 ` Doug Berger [this message]
2020-07-20 17:01 ` Florian Fainelli
2020-07-21 0:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b499451-623c-cabf-2c95-fc7019895b3d@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).