* [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang
@ 2021-03-05 9:45 Gustavo A. R. Silva
2021-04-20 20:23 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 9:45 UTC (permalink / raw)
To: Manish Chopra, Rahul Verma, David S. Miller, Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a goto statement instead of just letting the code
fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
index 08f9477d2ee8..35ec9aab3dc7 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
@@ -1685,6 +1685,7 @@ netxen_process_rcv_ring(struct nx_host_sds_ring *sds_ring, int max)
break;
case NETXEN_NIC_RESPONSE_DESC:
netxen_handle_fw_message(desc_cnt, consumer, sds_ring);
+ goto skip;
default:
goto skip;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang
2021-03-05 9:45 [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:23 ` Gustavo A. R. Silva
2021-05-18 0:08 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:23 UTC (permalink / raw)
To: Gustavo A. R. Silva, Manish Chopra, Rahul Verma, David S. Miller,
Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:45, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a goto statement instead of just letting the code
> fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> index 08f9477d2ee8..35ec9aab3dc7 100644
> --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> @@ -1685,6 +1685,7 @@ netxen_process_rcv_ring(struct nx_host_sds_ring *sds_ring, int max)
> break;
> case NETXEN_NIC_RESPONSE_DESC:
> netxen_handle_fw_message(desc_cnt, consumer, sds_ring);
> + goto skip;
> default:
> goto skip;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang
2021-04-20 20:23 ` Gustavo A. R. Silva
@ 2021-05-18 0:08 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Manish Chopra, Rahul Verma, David S. Miller,
Jakub Kicinski
Cc: GR-Linux-NIC-Dev, netdev, linux-kernel, linux-hardening
Hi,
I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:23, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:45, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a goto statement instead of just letting the code
>> fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
>> index 08f9477d2ee8..35ec9aab3dc7 100644
>> --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
>> +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
>> @@ -1685,6 +1685,7 @@ netxen_process_rcv_ring(struct nx_host_sds_ring *sds_ring, int max)
>> break;
>> case NETXEN_NIC_RESPONSE_DESC:
>> netxen_handle_fw_message(desc_cnt, consumer, sds_ring);
>> + goto skip;
>> default:
>> goto skip;
>> }
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:45 [PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:23 ` Gustavo A. R. Silva
2021-05-18 0:08 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).