From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Eric Dumazet <edumazet@google.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
syzbot <syzkaller@googlegroups.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>
Subject: Re: [PATCH net] netfilter: conntrack: avoid possible false sharing
Date: Wed, 9 Oct 2019 21:30:22 -0700 [thread overview]
Message-ID: <7b7193d5-c93f-b81a-f4a0-ad63ed8196c3@gmail.com> (raw)
In-Reply-To: <20191009212451.0522979f@cakuba.netronome.com>
On 10/9/19 9:24 PM, Jakub Kicinski wrote:
> On Wed, 9 Oct 2019 09:19:13 -0700, Eric Dumazet wrote:
>> As hinted by KCSAN, we need at least one READ_ONCE()
>> to prevent a compiler optimization.
>>
>> More details on :
>> https://github.com/google/ktsan/wiki/READ_ONCE-and-WRITE_ONCE#it-may-improve-performance
>>
>> [...]
>>
>> Fixes: cc16921351d8 ("netfilter: conntrack: avoid same-timeout update")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Reported-by: syzbot <syzkaller@googlegroups.com>
>> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
>> Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
>> Cc: Florian Westphal <fw@strlen.de>
>
> Applied, thank you.
>
> Not queuing for stable, please let me know if I should.
>
This is fine really, thanks.
prev parent reply other threads:[~2019-10-10 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 16:19 [PATCH net] netfilter: conntrack: avoid possible false sharing Eric Dumazet
2019-10-09 20:58 ` Pablo Neira Ayuso
2019-10-10 4:24 ` Jakub Kicinski
2019-10-10 4:30 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7193d5-c93f-b81a-f4a0-ad63ed8196c3@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jakub.kicinski@netronome.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=kadlec@netfilter.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).