From: santosh.shilimkar@oracle.com
To: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>,
netdev@vger.kernel.org, davem@davemloft.net,
rds-devel@oss.oracle.com
Cc: Dotan Barak <dotanb@dev.mellanox.co.il>
Subject: Re: [PATCH net] net/rds: Fix error handling in rds_ib_add_one()
Date: Tue, 1 Oct 2019 10:47:55 -0700 [thread overview]
Message-ID: <7b8bade4-fc23-6741-452a-23c36f24c57d@oracle.com> (raw)
In-Reply-To: <1569950462-37680-1-git-send-email-sudhakar.dindukurti@oracle.com>
On 10/1/19 10:21 AM, Sudhakar Dindukurti wrote:
> From: Dotan Barak <dotanb@dev.mellanox.co.il>
>
> rds_ibdev:ipaddr_list and rds_ibdev:conn_list are initialized
> after allocation some resources such as protection domain.
> If allocation of such resources fail, then these uninitialized
> variables are accessed in rds_ib_dev_free() in failure path. This
> can potentially crash the system. The code has been updated to
> initialize these variables very early in the function.
>
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Sudhakar Dindukurti <sudhakar.dindukurti@oracle.com>
> ---
Thanks Sudhakar !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
next prev parent reply other threads:[~2019-10-01 17:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 17:21 [PATCH net] net/rds: Fix error handling in rds_ib_add_one() Sudhakar Dindukurti
2019-10-01 17:47 ` santosh.shilimkar [this message]
2019-10-02 16:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b8bade4-fc23-6741-452a-23c36f24c57d@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=dotanb@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sudhakar.dindukurti@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).