From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BA4C43381 for ; Fri, 15 Feb 2019 22:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1543222D0 for ; Fri, 15 Feb 2019 22:56:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tkWqv9P+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394260AbfBOW4C (ORCPT ); Fri, 15 Feb 2019 17:56:02 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:40506 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394241AbfBOW4C (ORCPT ); Fri, 15 Feb 2019 17:56:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uneux88Vwf49hFPwcHcdPj0nADvwQCIZ/oEP4UwQdjw=; b=tkWqv9P+axlTFx3ttI6P/5+54 kinkqK22ZgElvSmM7i3ocEdJXyxDzok6LlEeyaiicQsPNfZS0p9qpNKyVBQtUDHLe2m41ikzP1FdK eLwP5LYeZ76wM2Ihm03/gFY3IPqadBlL7zAHKnfr/s3CQo42oSDWNMJ7FxY4dnouDB58jrcDbTfs6 zQmd4kz3PBBu6ugpU9mx5Q8hJXdY0W8gaZBvrbZ9QlLSZGuQ5gUAVItqbb7/elS0Uh+HWZMdrVpga RkQqpIJi5kGzTIMhi0uho33eS1XJw3wetOEzNFPR8GykszY7YKKTugxyxVutBsI+vKDmd5ZRRtyyw 1wEYBQk4A==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gumOm-0005di-Tx; Fri, 15 Feb 2019 22:56:00 +0000 Subject: Re: [PATCH bpf-next v2] bpf: make LWTUNNEL_BPF dependent on INET To: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org Cc: Peter Oskolkov References: <20190215175135.35549-1-posk@google.com> From: Randy Dunlap Message-ID: <7bbc8f63-3033-44ba-5b8e-ae597677bbe6@infradead.org> Date: Fri, 15 Feb 2019 14:55:58 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190215175135.35549-1-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/15/19 9:51 AM, Peter Oskolkov wrote: > Lightweight tunnels are L3 constructs that are used with IP/IP6. > > For example, lwtunnel_xmit is called from ip_output.c and > ip6_output.c only. > > Make the dependency explicit at least for LWT-BPF, as now they > call into IP routing. > > V2: added "Reported-by" below. > > Reported-by: Randy Dunlap > Signed-off-by: Peter Oskolkov Yes, that works. Thanks. Acked-by: Randy Dunlap # build-tested > --- > net/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/Kconfig b/net/Kconfig > index 5cb9de1aaf88..62da6148e9f8 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -403,7 +403,7 @@ config LWTUNNEL > > config LWTUNNEL_BPF > bool "Execute BPF program as route nexthop action" > - depends on LWTUNNEL > + depends on LWTUNNEL && INET > default y if LWTUNNEL=y > ---help--- > Allows to run BPF programs as a nexthop action following a route > -- ~Randy