Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support

From: netdev@kapio-technology.com
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Ido Schimmel <idosch@idosch.org>,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 net-next 0/2] mv88e6xxx: Add MAB offload support
Date: Tue, 15 Nov 2022 11:52:40 +0100	[thread overview]
Message-ID: <7c02d4f14e59a6e26431c086a9bb9643@kapio-technology.com> (raw)
In-Reply-To: <20221115102833.ahwnahrqstcs2eug@skbuf>

On 2022-11-15 11:28, Vladimir Oltean wrote:
> On Tue, Nov 15, 2022 at 11:26:55AM +0100, netdev@kapio-technology.com 
> wrote:
>> On 2022-11-15 10:30, Ido Schimmel wrote:
>> > On Sat, Nov 12, 2022 at 09:37:46PM +0100, Hans J. Schultz wrote:
>> > > This patchset adds MAB [1] offload support in mv88e6xxx.
>> > >
>> > > Patch #1: Fix a problem when reading the FID needed to get the VID.
>> > >
>> > > Patch #2: The MAB implementation for mv88e6xxx.
>> >
>> > Just to be sure, this was tested with bridge_locked_port.sh, right?
>> 
>> As I have the phy regression I have given notice of, that has simply 
>> not
>> been possible. After maybe 50 resets it worked for me at a point
>> (something to do with timing), and I tested it manually.
>> 
>> When I have tried to run the selftests, I get errors related to the 
>> phy
>> problem, which I have not been able to find a way around.
> 
> What PHY regression?

I had a discussion with Jacub, which resulted in me sending a mail to
maintainers on this. The problem is shown below...

the phy is marvell/6097/88e3082

------------[ cut here ]------------
WARNING: CPU: 0 PID: 332 at drivers/net/phy/phy.c:975
phy_error+0x28/0x54
Modules linked in:
CPU: 0 PID: 332 Comm: kworker/0:0 Tainted: G        W          6.0.0 #17
Hardware name: Freescale i.MX27 (Device Tree Support)
Workqueue: events_power_efficient phy_state_machine
   unwind_backtrace from show_stack+0x18/0x1c
   show_stack from dump_stack_lvl+0x28/0x30
   dump_stack_lvl from __warn+0xb8/0x114
   __warn from warn_slowpath_fmt+0x80/0xbc
   warn_slowpath_fmt from phy_error+0x28/0x54
   phy_error from phy_state_machine+0xbc/0x218
   phy_state_machine from process_one_work+0x17c/0x244
   process_one_work from worker_thread+0x248/0x2cc
   worker_thread from kthread+0xb0/0xbc
   kthread from ret_from_fork+0x14/0x2c
Exception stack(0xc4a71fb0 to 0xc4a71ff8)
1fa0:                                     00000000 00000000 00000000
00000000
1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000
1fe0: 00000000 00000000 00000000 00000000 00000013 00000000
---[ end trace 0000000000000000 ]---